Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 898d937

Browse files
authored
UI - Hide 'Logout' button when auth is disabled (#922)
1 parent f1dcf02 commit 898d937

File tree

12 files changed

+19
-12
lines changed

12 files changed

+19
-12
lines changed

quesma/quesma/ui/console_routes.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ func (qmc *QuesmaManagementConsole) createRouting() *mux.Router {
7676
if qmc.cfg.Elasticsearch.User == "" && qmc.cfg.Elasticsearch.Password == "" {
7777
logger.Warn().Msg("admin console authentication is disabled")
7878
} else {
79+
qmc.isAuthEnabled = true
7980
authenticatedRoutes.Use(authMiddleware)
8081
}
8182

quesma/quesma/ui/dashboard.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121

2222
func (qmc *QuesmaManagementConsole) generateDashboard() []byte {
2323
buffer := newBufferWithHead()
24-
buffer.Write(generateTopNavigation("dashboard"))
24+
buffer.Write(qmc.generateTopNavigation("dashboard"))
2525

2626
buffer.Html(`<main id="dashboard-main">` + "\n")
2727

quesma/quesma/ui/data_sources.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010

1111
func (qmc *QuesmaManagementConsole) generateDatasourcesPage() []byte {
1212
buffer := newBufferWithHead()
13-
buffer.Write(generateTopNavigation("data-sources"))
13+
buffer.Write(qmc.generateTopNavigation("data-sources"))
1414

1515
buffer.Html(`<main id="data-sources">`)
1616
buffer.Write(qmc.generateDatasources())

quesma/quesma/ui/html_utils.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ func generateSimpleTop(title string) []byte {
1818
return buffer.Bytes()
1919
}
2020

21-
func generateTopNavigation(target string) []byte {
21+
func (qmc *QuesmaManagementConsole) generateTopNavigation(target string) []byte {
2222
var buffer builder.HtmlBuffer
2323
buffer.Html(`<div class="topnav">` + "\n")
2424
buffer.Html(`<div class="topnav-menu">` + "\n")
@@ -76,7 +76,11 @@ func generateTopNavigation(target string) []byte {
7676
buffer.Html(` class="active"`)
7777
}
7878
buffer.Html(`><a href="/data-sources">Data sources</a></li>`)
79-
buffer.Html(`<li><a href="/logout">Logout</a></li>`)
79+
80+
if qmc.isAuthEnabled {
81+
buffer.Html(`<li><a href="/logout">Logout</a></li>`)
82+
}
83+
8084
buffer.Html("\n</ul>\n")
8185
buffer.Html("\n</div>\n")
8286

quesma/quesma/ui/ingest.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111

1212
func (qmc *QuesmaManagementConsole) generateIngestStatistics() []byte {
1313
buffer := newBufferWithHead()
14-
buffer.Write(generateTopNavigation("statistics"))
14+
buffer.Write(qmc.generateTopNavigation("statistics"))
1515

1616
buffer.Html(`<main id="statistics">`)
1717
buffer.Write(qmc.generateStatistics())

quesma/quesma/ui/live_tail.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515

1616
func (qmc *QuesmaManagementConsole) generateLiveTail() []byte {
1717
buffer := newBufferWithHead()
18-
buffer.Write(generateTopNavigation("queries"))
18+
buffer.Write(qmc.generateTopNavigation("queries"))
1919

2020
// This preserves scrolling, but does not work if new queries appear.
2121
buffer.Html(`<script>

quesma/quesma/ui/management_console.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ type (
102102
schemasProvider SchemasProvider
103103
totalUnsupportedQueries int
104104
tableResolver table_resolver.TableResolver
105+
106+
isAuthEnabled bool
105107
}
106108
SchemasProvider interface {
107109
AllSchemas() map[schema.TableName]schema.Schema

quesma/quesma/ui/routing.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010

1111
func (qmc *QuesmaManagementConsole) generateRouterStatisticsLiveTail() []byte {
1212
buffer := newBufferWithHead()
13-
buffer.Write(generateTopNavigation("routing-statistics"))
13+
buffer.Write(qmc.generateTopNavigation("routing-statistics"))
1414

1515
buffer.Html(`<main id="routing-statistics">`)
1616
buffer.Write(qmc.generateRouterStatistics())

quesma/quesma/ui/schemas.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
func (qmc *QuesmaManagementConsole) generateSchemas() []byte {
1111
buffer := newBufferWithHead()
12-
buffer.Write(generateTopNavigation("schemas"))
12+
buffer.Write(qmc.generateTopNavigation("schemas"))
1313
buffer.Html(`<main id="schemas">`)
1414

1515
schemas := qmc.schemasProvider.AllSchemas()

quesma/quesma/ui/table_resolver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
func (qmc *QuesmaManagementConsole) generateTableResolver() []byte {
1111

1212
buffer := newBufferWithHead()
13-
buffer.Write(generateTopNavigation("table_resolver"))
13+
buffer.Write(qmc.generateTopNavigation("table_resolver"))
1414

1515
buffer.Html(`<main id="table_resolver">`)
1616

0 commit comments

Comments
 (0)