Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 89ca35d

Browse files
committed
Extracting consts
1 parent 92a523e commit 89ca35d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

platform/frontend_connectors/physical_functions.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ const (
66
CLickhouseDateHourFunction = "toHour"
77
ClickhouseFromUnixTimeFunction64mili = "fromUnixTimestamp64Milli"
88
ClickhouseFromUnixTimeFunction = "fromUnixTimestamp"
9+
ClickhouseToTimezone = "toTimezone"
10+
ClickhousetoUnixTimestamp64Milli = "toUnixTimestamp64Milli"
911
DorisDateHourFunction = "HOUR"
1012
DorisFromUnixTimeFunction = "FROM_UNIXTIME"
1113
DorisFromUnixTimeFunction64mili = "FROM_MILLISECOND"

platform/frontend_connectors/schema_transformer.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,16 +1109,16 @@ func (s *SchemaCheckPass) acceptIntsAsTimestamps(indexSchema schema.Schema, quer
11091109
}
11101110

11111111
visitor.OverrideVisitFunction = func(b *model.BaseExprVisitor, f model.FunctionExpr) interface{} {
1112-
if f.Name == "toUnixTimestamp64Milli" && len(f.Args) == 1 {
1112+
if f.Name == ClickhousetoUnixTimestamp64Milli && len(f.Args) == 1 {
11131113
if col, ok := model.ExtractColRef(f.Args[0]); ok && table.IsInt(col.ColumnName) {
11141114
// erases toUnixTimestamp64Milli
11151115
return f.Args[0]
11161116
}
11171117
}
1118-
if f.Name == "toTimezone" && len(f.Args) == 2 {
1118+
if f.Name == ClickhouseFromUnixTimeFunction64mili && len(f.Args) == 2 {
11191119
if col, ok := model.ExtractColRef(f.Args[0]); ok && table.IsInt(col.ColumnName) {
11201120
// adds fromUnixTimestamp64Milli
1121-
return model.NewFunction("toTimezone", model.NewFunction(model.FromUnixTimeFunction64mili, f.Args[0]), f.Args[1])
1121+
return model.NewFunction(ClickhouseToTimezone, model.NewFunction(ClickhouseFromUnixTimeFunction64mili, f.Args[0]), f.Args[1])
11221122
}
11231123
}
11241124
return visitFunction(b, f)

0 commit comments

Comments
 (0)