[sample_flights, quickfix] Add doc_count = 0 if no DB result in filter (#1329)

Also adds all requests from `flights` as tests. I think they all pass,
but I need to update results in last 2 of them.

Author: trzysiek

platform/model/bucket_aggregations/filter.go

@@ -22,11 +22,14 @@ func (query FilterAgg) AggregationType() model.AggregationType {
 }
 
 func (query FilterAgg) TranslateSqlResponseToJson(rows []model.QueryResultRow) model.JsonMap {
+	var docCount any
 	if len(rows) == 0 {
-		logger.WarnWithCtx(query.ctx).Msg("no rows returned for filter aggregation")
-		return make(model.JsonMap, 0)
+		logger.WarnWithCtxAndThrottling(query.ctx, "filter", "no rows", "no rows returned for filter aggregation")
+		docCount = 0
+	} else {
+		docCount = rows[0].LastColValue()
 	}
-	return model.JsonMap{"doc_count": rows[0].Cols[0].Value}
+	return model.JsonMap{"doc_count": docCount}
 }
 
 func (query FilterAgg) String() string {

platform/parsers/elastic_query_dsl/aggregation_parser_test.go

@@ -645,7 +645,7 @@ var aggregationTests = []struct {
 }*/
 
 func allAggregationTests() []testdata.AggregationTestCase {
-	const lowerBoundTestNr = 90
+	const lowerBoundTestNr = 220
 	allTests := make([]testdata.AggregationTestCase, 0, lowerBoundTestNr)
 
 	add := func(testsToAdd []testdata.AggregationTestCase, testFilename string) {
@@ -660,6 +660,7 @@ func allAggregationTests() []testdata.AggregationTestCase {
 	add(testdata.AggregationTestsWithDates, "dates")
 	add(testdata.GrafanaAggregationTests, "grafana")
 	add(testdata.KibanaSampleDataEcommerce, "kibana-sample-data-ecommerce")
+	add(testdata.KibanaSampleDataFlights, "kibana-sample-data-flights")
 	add(testdata.KibanaSampleDataLogs, "kibana-sample-data-logs")
 	add(testdata.PipelineAggregationTests, "pipeline_agg_req")
 	add(dashboard_1.AggregationTests, "dashboard-1/agg_req")

platform/parsers/elastic_query_dsl/pancake_sql_query_generation_test.go

@@ -48,11 +48,14 @@ func TestPancakeQueryGeneration(t *testing.T) {
 
 	for i, test := range allAggregationTests() {
 		t.Run(test.TestName+"("+strconv.Itoa(i)+")", func(t *testing.T) {
+			// sample_flights
+			if test.TestName == "TODO Airport Connections (Hover Over Airport)(file:kibana-sample-data-flights,nr:14)" {
+				t.Skip("Fixing right now")
+			}
 			// sample_ecommerce
 			if test.TestName == "TODO Top products this/last week(file:kibana-sample-data-ecommerce,nr:9)" {
 				t.Skip("works IRL, need to update test's schema. It's already WIP https://github.com/QuesmaOrg/quesma/pull/1255. Let's wait for merge.")
 			}
-
 			// sample_logs
 			if test.TestName == "Table gz, css, zip, etc.(file:kibana-sample-data-logs,nr:6)" {
 				t.Skip()
@@ -152,7 +155,7 @@ func TestPancakeQueryGeneration(t *testing.T) {
 			}
 
 			// FIXME we can quite easily remove 'probability' and 'seed' from above - just start remembering them in RandomSampler struct and print in JSON response.
-			acceptableDifference := []string{"probability", "seed", bucket_aggregations.OriginalKeyName,
+			acceptableDifference := []string{"probability", "seed", bucket_aggregations.OriginalKeyName, "_id", "_score",
 				"bg_count", "doc_count_error_upper_bound"} // Don't know why, but those 2 are still needed in new (clients/ophelia) tests. Let's fix it in another PR
 			if len(test.AdditionalAcceptableDifference) > 0 {
 				acceptableDifference = append(acceptableDifference, test.AdditionalAcceptableDifference...)

platform/testdata/aggregation_requests.go

@@ -3213,7 +3213,8 @@ var AggregationTests = []AggregationTestCase{
 								"1-bucket": {
 									"1-metric": {
 										"value": null
-									}
+									},
+									"doc_count": 0
 								},
 								"doc_count": 0,
 								"key": 1708732800000,
@@ -3223,7 +3224,8 @@ var AggregationTests = []AggregationTestCase{
 								"1-bucket": {
 									"1-metric": {
 										"value": null
-									}
+									},
+									"doc_count": 0
 								},
 								"doc_count": 0,
 								"key": 1708776000000,