[Grafana] Allow adding more than 1000 empty buckets (#1325)

trzysiek · web-flow · commit e3b274ff8388 · 2025-03-02T18:41:06.000Z
I think Elastic has 65536 (2^16), so setting something similar. After this second PR, all date_histograms start looking exactly the same as from Elastic: <img width="1441" alt="Screenshot 2025-03-02 at 18 04 43" src="https://github.com/user-attachments/assets/3b174a93-66e6-410e-b0d1-c39ae19daf71" />
diff --git a/platform/model/bucket_aggregations/date_histogram.go b/platform/model/bucket_aggregations/date_histogram.go
@@ -26,7 +26,7 @@ const (
 	// with date_histogram's map (it already has a "valid", processed key, after TranslateSqlResponseToJson)
 	OriginalKeyName      = "__quesma_originalKey"
 	NoExtendedBound      = int64(-1) // -1 and not e.g. 0, as 0 is a valid value
-	maxEmptyBucketsAdded = 1000
+	maxEmptyBucketsAdded = 100000
 )
 
 type DateHistogram struct {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ const (`
`26`	`26`	`// with date_histogram's map (it already has a "valid", processed key, after TranslateSqlResponseToJson)`
`27`	`27`	`OriginalKeyName = "__quesma_originalKey"`
`28`	`28`	`NoExtendedBound = int64(-1) // -1 and not e.g. 0, as 0 is a valid value`
`29`		`- maxEmptyBucketsAdded = 1000`
	`29`	`+ maxEmptyBucketsAdded = 100000`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`type DateHistogram struct {`