Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit eab9572

Browse files
authored
splitTimeRangeExt is considered harmful (#1454)
`splitTimeRangeExt` optimization may break some queries. Let's go ahead and disable it and proceed with further investigation.
1 parent 38b6652 commit eab9572

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

platform/optimize/pipeline.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,13 @@ func NewOptimizePipeline(config *config.QuesmaConfiguration) model.QueryTransfor
2727
// TODO remove this line when splitTimeRange is removed
2828
// this is just to satisfy the linter
2929
_ = &splitTimeRange{}
30+
_ = &splitTimeRangeExt{}
3031
return &OptimizePipeline{
3132
config: config,
3233
optimizations: []OptimizeTransformer{
3334
&truncateDate{truncateTo: 5 * time.Minute},
3435
&cacheQueries{},
3536
&materializedViewReplace{},
36-
// TODO finally remove this transformer
37-
// commenting out splitTimeRange for now
38-
// as we have splitTimeRangeExt that uses novel approach
39-
// of splitting queries based on time range
40-
// executing them in parallel and finally merging results
41-
// &splitTimeRange{},
42-
&splitTimeRangeExt{},
4337
},
4438
}
4539
}

0 commit comments

Comments
 (0)