This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Adapt doris schema type #1495
Merged
Adapt doris schema type #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLiang-0
requested review from
avelanarius,
jakozaur,
mieciu,
nablaone and
trzysiek
Contributor
Author
|
/run-it |
pdelewski
reviewed
Jul 16, 2025
platform/database_common/schema.go
Outdated
| return reflect.TypeOf(map[string]string{}) | ||
| case "Unknown": | ||
| return reflect.TypeOf(UnknownType{}) | ||
| func NewBaseTypeWithInstanceName(typeName string, instanceName string) BaseType { |
Contributor
There was a problem hiding this comment.
I think it would be better to use some const enum instead of string as instanceName
pdelewski
reviewed
Jul 16, 2025
platform/database_common/schema.go
Outdated
|
|
||
| func GetTypeResolver(instanceName string) TypeResolver { | ||
| var r TypeResolver | ||
| if instanceName == "doris" { |
Contributor
There was a problem hiding this comment.
As above, const enum would be better IMO
Contributor
|
Everything looks good to me, except for the point raised above. |
Contributor
Author
Thanks for your review |
Contributor
Author
|
/run-it |
pdelewski
approved these changes
Jul 16, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
Fixing pretty obvious mistake from recently introduced in #1495
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.