This repository was archived by the owner on Nov 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Implement hydrolix ddl #1480
Merged
Merged
Implement hydrolix ddl #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cb4539 to
c55d8e4
Compare
Contributor
Author
|
/run-it |
54ab46d to
6c0c356
Compare
Contributor
Author
|
/run-it |
1ddd574 to
af2c054
Compare
Contributor
Author
|
/run-it |
d968328 to
bddae1a
Compare
mieciu
reviewed
Jul 2, 2025
mieciu
reviewed
Jul 2, 2025
mieciu
reviewed
Jul 2, 2025
mieciu
reviewed
Jul 2, 2025
Co-authored-by: Przemysław Hejman <[email protected]> Signed-off-by: Przemyslaw Delewski <[email protected]>
Signed-off-by: Przemyslaw Delewski <[email protected]>
d0e7648 to
f0da77e
Compare
Contributor
Author
|
/run-it |
a96d717 to
4d145ba
Compare
f9dfcf1 to
955dd01
Compare
Contributor
Author
|
/run-it |
372e2b1 to
019700f
Compare
019700f to
4973f5e
Compare
Contributor
Author
|
/run-it |
nablaone
suggested changes
Jul 29, 2025
Member
nablaone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Panics and access to the map in the lowerer need to be addressed.
4bdae9c to
f0a1879
Compare
Contributor
Author
|
/run-it |
nablaone
approved these changes
Jul 29, 2025
Member
nablaone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is about implementing hydrolix lowere and backend connector
Example of backend connectors def