Skip to content

Commit c9dbd46

Browse files
committed
soup: skip updating approval info if already present.
1 parent 6f7a95b commit c9dbd46

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/soup-approval-verification-workflow.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,12 @@ jobs:
192192
continue
193193
fi
194194
195+
if jq -e '.metadata.approval.by != null and .metadata.approval.by != "" and
196+
.metadata.approval.date != null and .metadata.approval.date != ""' "$FILE" > /dev/null; then
197+
echo "$FILE already has approval info filled"
198+
continue
199+
fi
200+
195201
jq --arg approved_by "$APPROVED_BY" --arg approved_on "$APPROVED_ON" \
196202
'.metadata.approval.by = $approved_by | .metadata.approval.date = $approved_on' \
197203
"$FILE" > "${FILE}.tmp" && mv "${FILE}.tmp" "$FILE"

.github/workflows/soup-generate-all-missing.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,3 @@ jobs:
1717
repository: ${{ github.event.repository.name }}
1818
gh-api-token: ${{ env.GH_API_TOKEN }}
1919
soup-approvers: ${{ vars.SOUP_APPROVERS }}
20-
base-branch: origin/${{ github.event.pull_request.base.ref || 'main' }}

0 commit comments

Comments
 (0)