Skip to content

Commit 770e306

Browse files
author
QuickSander
committed
fix: timeout/error crashes hap-nodejs since it calls callback twice.
1 parent 7584c45 commit 770e306

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

index.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -531,10 +531,9 @@ HttpPushRgb.prototype = {
531531
auth: {
532532
user: this.username,
533533
pass: this.password
534-
}
535-
},
536-
function(error, response, body) {
537-
callback(error, response, body);
534+
}},
535+
function(error, response, body) {
536+
callback(error, response, body);
538537
});
539538
},
540539

@@ -548,13 +547,17 @@ HttpPushRgb.prototype = {
548547
* @return {Boolean} true: Error occurred, false otherwise
549548
*/
550549
_handleHttpErrorResponse: function(functionStr, error, response, responseBody, callback) {
550+
var errorOccurred = false;
551551
if (error) {
552552
this.log(functionStr +' failed: %s', error.message);
553553
callback(error);
554+
errorOccurred = true;
554555
} else if (response.statusCode != 200) {
555556
this.log(functionStr + ' returned HTTP error code: %s: "%s"', response.statusCode, responseBody);
556557
callback( new Error("Received HTTP error code " + response.statusCode + ': "' + responseBody + '"') );
558+
errorOccurred = true;
557559
}
560+
return errorOccurred;
558561
},
559562

560563
/**

0 commit comments

Comments
 (0)