Fix latest go sdk version to push the right images (temporalio#458)

Author: dnr

Diff for: .github/workflows/ci.yaml

@@ -14,7 +14,7 @@ jobs:
   latest-sdk-versions:
     runs-on: 'ubuntu-latest'
     outputs:
-      go_latest: 'v1.26.1'
+      go_latest: '1.26.1'
       typescript_latest: '1.9.3'
       java_latest: '1.23.0'
       python_latest: '1.4.0'
@@ -119,7 +119,7 @@ jobs:
     uses: ./.github/workflows/go.yaml
     with:
       version: ${{ needs.latest-sdk-versions.outputs.go_latest }}
-      version-is-repo-ref: true
+      version-is-repo-ref: false
       features-repo-ref: ${{ github.head_ref }}
       features-repo-path: ${{ github.event.pull_request.head.repo.full_name }}
 
@@ -157,7 +157,7 @@ jobs:
     # TODO: Find some way to automatically upgrade to "latest"
     with:
       do-push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
-      go-repo-ref: ${{ needs.latest-sdk-versions.outputs.go_latest }}
+      go-ver: 'v${{ needs.latest-sdk-versions.outputs.go_latest }}'
       ts-ver: 'v${{ needs.latest-sdk-versions.outputs.typescript_latest }}'
       java-ver: 'v${{ needs.latest-sdk-versions.outputs.java_latest }}'
       py-ver: 'v${{ needs.latest-sdk-versions.outputs.python_latest }}'

Diff for: sdkbuild/go.go

@@ -18,8 +18,9 @@ type BuildGoProgramOptions struct {
 	// Directory that will have a temporary directory created underneath
 	BaseDir string
 	// If not set, not put in go.mod which means go mod tidy will automatically
-	// use latest. If set and does not start with a "v", it is assumed to be a
-	// path, otherwise it is a specific version.
+	// use latest. If set and contains a slash, it is assumed to be a path,
+	// otherwise it is a specific version (with leading "v" is trimmed if
+	// present).
 	Version string
 	// The SDK Repository import to use. If unspecified we default to go.temporal.io/sdk
 	// If specified version must also be provided
@@ -79,22 +80,22 @@ func BuildGoProgram(ctx context.Context, options BuildGoProgramOptions) (*GoProg
 	goMod := options.GoModContents
 	// If a version is specified, overwrite the SDK to use that
 	if options.Version != "" || options.SDKRepository != "" {
-		// If version does not start with a "v" we assume path unless the SDK repository is provided
+		// If version has a "/" we assume path unless the SDK repository is provided
 		if options.SDKRepository != "" {
 			if options.Version == "" {
 				return nil, errors.New("Version must be provided alongside SDKRepository")
 			}
-			goMod += fmt.Sprintf("\nreplace %s => %s %s", sdkImport, options.SDKRepository, options.Version)
-		} else if strings.HasPrefix(options.Version, "v") {
-			goMod += fmt.Sprintf("\nreplace %s => %s %s", sdkImport, sdkImport, options.Version)
+			goMod += fmt.Sprintf("\nreplace %s => %s v%s", sdkImport, options.SDKRepository, strings.TrimPrefix(options.Version, "v"))
+		} else if !strings.Contains(options.Version, "/") {
+			goMod += fmt.Sprintf("\nreplace %s => %s v%s", sdkImport, sdkImport, strings.TrimPrefix(options.Version, "v"))
 		} else {
 			absVersion, err := filepath.Abs(options.Version)
 			if err != nil {
-				return nil, fmt.Errorf("version does not start with 'v' and cannot get abs dir: %w", err)
+				return nil, fmt.Errorf("version has a '/' and cannot get abs dir: %w", err)
 			}
 			relVersion, err := filepath.Rel(dir, absVersion)
 			if err != nil {
-				return nil, fmt.Errorf("version does not start with 'v' and unable to relativize: %w", err)
+				return nil, fmt.Errorf("version has a '/' and unable to relativize: %w", err)
 			}
 			goMod += fmt.Sprintf("\nreplace %s => %s", sdkImport, filepath.ToSlash(relVersion))
 		}