fix(utils): deprecated-api-warnings-from-lighthouse-fixed (#697)

* deprecatedWindowMembers-added

* add-changeset

* fix(sandbox): filter deprecated window properties to prevent Lighthouse penalty

Accessing window.SharedStorage and window.AttributionReporting during
sandbox initialization triggers Chrome "Deprecated feature used" warnings,
which Lighthouse reads and penalizes Best Practices score (~81 instead of 100).

Add a maintainable blocklist (DEPRECATED_WINDOW_PROPERTIES) and filter these
properties in both isValidMemberName() and readMainInterfaces() to prevent
the property access that triggers the warnings.

Closes #313

* adjust-constant

* prettier

---------

Co-authored-by: Alex Sadowski <alex@zephy.com>
Co-authored-by: SurceBeats <subcero@gmail.com>
Co-authored-by: Alex Sadowski <asado@softserveinc.com>

Author: 4 people

.changeset/polite-jobs-relate.md

@@ -0,0 +1,5 @@
+---
+'@qwik.dev/partytown': patch
+---
+
+Fix Lighthouse deprecated API warnings by skipping Chrome Privacy Sandbox properties (SharedStorage, AttributionReporting) during window introspection

src/lib/sandbox/read-main-platform.ts

@@ -1,5 +1,6 @@
 import {
   createElementFromConstructor,
+  DEPRECATED_WINDOW_PROPERTIES,
   getConstructorName,
   getNodeName,
   isValidMemberName,
@@ -83,6 +84,7 @@ export const readMainInterfaces = () => {
   // get all HTML*Element constructors on window
   // and create each element to get their implementation
   const elms = Object.getOwnPropertyNames(mainWindow)
+    .filter((interfaceName) => !DEPRECATED_WINDOW_PROPERTIES.has(interfaceName))
     .map((interfaceName) => createElementFromConstructor(docImpl, interfaceName))
     .filter((elm) => {
       if (!elm) {

src/lib/utils.ts

@@ -37,13 +37,27 @@ export const getConstructorName = (obj: Object) => {
 
 export const startsWith = (str: string, val: string) => str.startsWith(val);
 
+// Chrome APIs that trigger deprecation warnings when accessed on window.
+// Accessing these during platform introspection causes console noise.
+// https://github.com/QwikDev/partytown/issues/694
+export const DEPRECATED_WINDOW_PROPERTIES = new Set([
+  'sharedStorage',
+  'SharedStorage',
+  'AttributionReporting',
+  'attributionReporting',
+  'AttributionReportingRequestOptions',
+  'attributionSrc',
+  'setAttributionReporting',
+]);
+
 export const isValidMemberName = (memberName: string) =>
   !(
     startsWith(memberName, 'webkit') ||
     startsWith(memberName, 'toJSON') ||
     startsWith(memberName, 'constructor') ||
     startsWith(memberName, 'toString') ||
-    startsWith(memberName, '_')
+    startsWith(memberName, '_') ||
+    DEPRECATED_WINDOW_PROPERTIES.has(memberName)
   );
 
 export const getLastMemberName = (applyPath: ApplyPath, i?: number) => {

tests/unit/utils.spec.ts

@@ -1,5 +1,9 @@
 import * as assert from 'uvu/assert';
-import { createElementFromConstructor } from '../../src/lib/utils';
+import {
+  createElementFromConstructor,
+  DEPRECATED_WINDOW_PROPERTIES,
+  isValidMemberName,
+} from '../../src/lib/utils';
 import { suite } from './utils';
 
 const test = suite();
@@ -51,4 +55,33 @@ test('createElementFromConstructor, HTML', ({ doc }) => {
   assert.is(createElementFromConstructor(doc, 'IntersectionObserver'), undefined);
 });
 
+test('isValidMemberName rejects deprecated window properties', () => {
+  for (const prop of DEPRECATED_WINDOW_PROPERTIES) {
+    assert.is(isValidMemberName(prop), false, `${prop} should be rejected`);
+  }
+});
+
+test('isValidMemberName rejects known invalid prefixes', () => {
+  assert.is(isValidMemberName('webkitSpeechRecognition'), false);
+  assert.is(isValidMemberName('toJSON'), false);
+  assert.is(isValidMemberName('constructor'), false);
+  assert.is(isValidMemberName('toString'), false);
+  assert.is(isValidMemberName('_private'), false);
+});
+
+test('isValidMemberName accepts valid member names', () => {
+  assert.is(isValidMemberName('document'), true);
+  assert.is(isValidMemberName('localStorage'), true);
+  assert.is(isValidMemberName('fetch'), true);
+  assert.is(isValidMemberName('HTMLDivElement'), true);
+  assert.is(isValidMemberName('addEventListener'), true);
+});
+
+test('DEPRECATED_WINDOW_PROPERTIES contains expected entries', () => {
+  assert.ok(DEPRECATED_WINDOW_PROPERTIES.has('SharedStorage'));
+  assert.ok(DEPRECATED_WINDOW_PROPERTIES.has('sharedStorage'));
+  assert.ok(DEPRECATED_WINDOW_PROPERTIES.has('AttributionReporting'));
+  assert.ok(DEPRECATED_WINDOW_PROPERTIES.has('attributionReporting'));
+});
+
 test.run();