-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
[STAGE-2] incomplete implementationRemove this label when implementation is completeRemove this label when implementation is complete[STAGE-2] not fully covered by tests yetRemove this label when tests are verified to cover the implementationRemove this label when tests are verified to cover the implementation[STAGE-2] unresolved discussions leftRemove this label when all critical discussions are resolved on the issueRemove this label when all critical discussions are resolved on the issue[STAGE-3] docs changes not added yetRemove this label when the necessary documentation for the feature / change is addedRemove this label when the necessary documentation for the feature / change is added[STAGE-3] missing 2 reviews for RFC PRsRemove this label when at least 2 core team members reviewed and approved the RFC implementationRemove this label when at least 2 core team members reviewed and approved the RFC implementation
Description
Is your feature request related to a problem?
This feature is unrelated to any problem but represents a significant performance improvement for the build step since Biome linter is much faster than Eslint.
Biome provides a migration tool that makes it a breeze to migrate the Eslint configuration.
Describe the solution you'd like
The solution would consist of a PR with the following changes:
- Migrate Eslint configuration to Biome, including rules defined in
eslint-plugin-qwik
, using Biome's migration tool - Install Biome and uninstall Eslint-related packages from
package.json
- Modify the
lint
command to use Biome instead of Eslint - Deprecate
eslint-plugin-qwik
Describe alternatives you've considered
AFAIK, Biome is the most performant linter on the market and, since it provides a migration tool, I have not considered other alternatives.
Additional context
Performance comparison between Eslint and Biome published on Biome's website:
maiieul, ShrJamal and lieranderlPatrickJS, gustavocadev, CristianMR, tanftw, InsaneNaman and 3 more
Metadata
Metadata
Assignees
Labels
[STAGE-2] incomplete implementationRemove this label when implementation is completeRemove this label when implementation is complete[STAGE-2] not fully covered by tests yetRemove this label when tests are verified to cover the implementationRemove this label when tests are verified to cover the implementation[STAGE-2] unresolved discussions leftRemove this label when all critical discussions are resolved on the issueRemove this label when all critical discussions are resolved on the issue[STAGE-3] docs changes not added yetRemove this label when the necessary documentation for the feature / change is addedRemove this label when the necessary documentation for the feature / change is added[STAGE-3] missing 2 reviews for RFC PRsRemove this label when at least 2 core team members reviewed and approved the RFC implementationRemove this label when at least 2 core team members reviewed and approved the RFC implementation