Skip to content

[✨] Improve input types #35

@maiieul

Description

@maiieul

Is your feature request related to a problem?

At the time of writing, current implementation is the following:

input: {
    autoComplete?:
      | HTMLInputAutocompleteAttribute
      | Omit<HTMLInputAutocompleteAttribute, string>
      | undefined;
    'bind:checked'?: Signal<boolean | undefined>;
    'bind:value'?: Signal<string | undefined>;
    enterKeyHint?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send' | undefined;
    height?: Size | undefined;
    max?: number | string | undefined;
    maxLength?: number | undefined;
    min?: number | string | undefined;
    minLength?: number | undefined;
    step?: number | string | undefined;
    type?: HTMLInputTypeAttribute | undefined;
    value?: string | ReadonlyArray<string> | number | undefined | null | FormDataEntryValue;
    width?: Size | undefined;
    children?: undefined;
  } & (
    | {
        type?:
          | Exclude<HTMLInputTypeAttribute, 'button' | 'reset' | 'submit' | 'checkbox' | 'radio'>
          | undefined;
        'bind:checked'?: undefined;
      }
    | {
        type?: 'button' | 'reset' | 'submit';
        'bind:value'?: undefined;
        'bind:checked'?: undefined;
        autoComplete?: undefined;
      }
    | {
        type?: 'checkbox' | 'radio';
        'bind:value'?: undefined;
        autoComplete?: undefined;
      }
  ) &
    (
      | {
          type?: Exclude<HTMLInputTypeAttribute, 'button'> | undefined;
          popovertarget?: undefined;
          popovertargetaction?: undefined;
        }
      | {
          type: 'button';
          popovertarget?: string | undefined;
          popovertargetaction?: PopoverTargetAction | undefined;
        }
    );

But as explained in QwikDev/qwik#6398, it breaks on Checkbox components that use input of type checkbox under the hood and the bind: syntax.

As we said in QwikDev/qwik#6398, we're going to simplify it with

    type?: HTMLInputTypeAttribute | undefined;

we can try to improve upon it later.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions