-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
[STAGE-2] incomplete implementationRemove this label when implementation is completeRemove this label when implementation is complete[STAGE-2] not fully covered by tests yetRemove this label when tests are verified to cover the implementationRemove this label when tests are verified to cover the implementation[STAGE-2] unresolved discussions leftRemove this label when all critical discussions are resolved on the issueRemove this label when all critical discussions are resolved on the issue[STAGE-3] docs changes not added yetRemove this label when the necessary documentation for the feature / change is addedRemove this label when the necessary documentation for the feature / change is added[STAGE-3] missing 2 reviews for RFC PRsRemove this label when at least 2 core team members reviewed and approved the RFC implementationRemove this label when at least 2 core team members reviewed and approved the RFC implementation
Description
Is your feature request related to a problem?
At the time of writing, current implementation is the following:
input: {
autoComplete?:
| HTMLInputAutocompleteAttribute
| Omit<HTMLInputAutocompleteAttribute, string>
| undefined;
'bind:checked'?: Signal<boolean | undefined>;
'bind:value'?: Signal<string | undefined>;
enterKeyHint?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send' | undefined;
height?: Size | undefined;
max?: number | string | undefined;
maxLength?: number | undefined;
min?: number | string | undefined;
minLength?: number | undefined;
step?: number | string | undefined;
type?: HTMLInputTypeAttribute | undefined;
value?: string | ReadonlyArray<string> | number | undefined | null | FormDataEntryValue;
width?: Size | undefined;
children?: undefined;
} & (
| {
type?:
| Exclude<HTMLInputTypeAttribute, 'button' | 'reset' | 'submit' | 'checkbox' | 'radio'>
| undefined;
'bind:checked'?: undefined;
}
| {
type?: 'button' | 'reset' | 'submit';
'bind:value'?: undefined;
'bind:checked'?: undefined;
autoComplete?: undefined;
}
| {
type?: 'checkbox' | 'radio';
'bind:value'?: undefined;
autoComplete?: undefined;
}
) &
(
| {
type?: Exclude<HTMLInputTypeAttribute, 'button'> | undefined;
popovertarget?: undefined;
popovertargetaction?: undefined;
}
| {
type: 'button';
popovertarget?: string | undefined;
popovertargetaction?: PopoverTargetAction | undefined;
}
);
But as explained in QwikDev/qwik#6398, it breaks on Checkbox
components that use input of type checkbox under the hood and the bind:
syntax.
As we said in QwikDev/qwik#6398, we're going to simplify it with
type?: HTMLInputTypeAttribute | undefined;
we can try to improve upon it later.
Metadata
Metadata
Assignees
Labels
[STAGE-2] incomplete implementationRemove this label when implementation is completeRemove this label when implementation is complete[STAGE-2] not fully covered by tests yetRemove this label when tests are verified to cover the implementationRemove this label when tests are verified to cover the implementation[STAGE-2] unresolved discussions leftRemove this label when all critical discussions are resolved on the issueRemove this label when all critical discussions are resolved on the issue[STAGE-3] docs changes not added yetRemove this label when the necessary documentation for the feature / change is addedRemove this label when the necessary documentation for the feature / change is added[STAGE-3] missing 2 reviews for RFC PRsRemove this label when at least 2 core team members reviewed and approved the RFC implementationRemove this label when at least 2 core team members reviewed and approved the RFC implementation