Merge pull request #8554 from QwikDev/explicit-rewrite-roots

fix(routing): prefix roots should point to root

Author: wmertens

packages/qwik-router/src/buildtime/runtime-generation/generate-routes.ts

@@ -198,7 +198,7 @@ function serializeBuildTrie(
   }
 
   // _G rewrite target
-  if (node._G) {
+  if (node._G != null) {
     lines.push(`${nextIndent}_G: ${JSON.stringify(node._G)},`);
   }
 

packages/qwik-router/src/runtime/src/routing.ts

@@ -164,7 +164,7 @@ function resolveLoaders(
   node: RouteData,
   gatheredLayouts: ModuleLoader[]
 ): ModuleLoader[] | undefined {
-  if (node._G) {
+  if (node._G != null) {
     // Rewrite: re-walk from root using _G's keys
     const keys = (node._G as string).split('/').filter((p) => p.length > 0);
     const target = walkTrieKeys(root, keys);
@@ -176,7 +176,7 @@ function resolveLoaders(
 
     // If the target node doesn't have _I directly, check group children
     // (e.g., root index inside (common) group, or routes inside pathless groups)
-    if (!targetNode._I && !targetNode._G) {
+    if (!targetNode._I && targetNode._G == null) {
       const indexResult = findIndexNode(targetNode);
       if (indexResult) {
         for (const g of indexResult.groups) {
@@ -350,7 +350,7 @@ function tryWildcardMatch(
  * node and the groups entered to reach it.
  */
 function findIndexNode(node: RouteData): { target: RouteData; groups: RouteData[] } | undefined {
-  if (node._I || node._G) {
+  if (node._I || node._G != null) {
     return { target: node, groups: [] };
   }
   if (node._M) {
@@ -502,7 +502,7 @@ function matchRouteTree(
     // Check if _I is in a group child (e.g. (common)/index.tsx is the root "/" route)
     // This must come before _A checks so that an index route takes priority over
     // a rest wildcard with empty value.
-    if (!node._I && !node._G) {
+    if (!node._I && node._G == null) {
       const indexResult = findIndexNode(node);
       if (indexResult) {
         collectNodeMeta(
@@ -518,7 +518,7 @@ function matchRouteTree(
     }
 
     // Check for _A (rest wildcard with empty value) on the node itself
-    if (!node._I && !node._G && node._A) {
+    if (!node._I && node._G == null && node._A) {
       const next = node._A as RouteData;
       const paramName = next._P!;
       params[paramName as string] = '';
@@ -533,7 +533,7 @@ function matchRouteTree(
     }
 
     // Also check _M groups for _A with empty value
-    if (!node._I && !node._G) {
+    if (!node._I && node._G == null) {
       const restInfo = findRestNode(node);
       if (restInfo) {
         const next = restInfo.next;

packages/qwik-router/src/runtime/src/routing.unit.ts

@@ -425,6 +425,32 @@ test('loadRoute — _G with params preserves captured params', async () => {
   assert.deepEqual(result.$params$, { slug: 'my-post' });
 });
 
+test('loadRoute — _G empty string rewrite resolves prefix root to index', async () => {
+  const rootLayout = makeLoader();
+  const pageLoader = makeLoader();
+  const routes: RouteData = {
+    _L: rootLayout,
+    _M: [
+      {
+        _I: pageLoader,
+      },
+    ],
+    en: {
+      _G: '',
+    },
+    de: {
+      _G: '',
+    },
+  };
+  const resultEn = await loadRoute(routes, false, '/en');
+  assert.isFalse(resultEn.$notFound$);
+  assert.equal(resultEn.$mods$.length, 2); // rootLayout + pageLoader
+
+  const resultDe = await loadRoute(routes, false, '/de');
+  assert.isFalse(resultDe.$notFound$);
+  assert.equal(resultDe.$mods$.length, 2);
+});
+
 test('loadRoute — _G target not found returns 404', async () => {
   const routes: RouteData = {
     es: {