Skip to content

Commit 89947db

Browse files
authored
Merge pull request #7272 from QwikDev/v2-cleanup-fixes
chore: cleanup and docs fixes
2 parents bd9dbf1 + a3c37b3 commit 89947db

File tree

5 files changed

+10
-15
lines changed

5 files changed

+10
-15
lines changed

packages/docs/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"prism-themes": "1.9.0",
4242
"prismjs": "1.29.0",
4343
"puppeteer": "22.13.1",
44-
"qwik-image": "0.0.15",
44+
"qwik-image": "0.0.16",
4545
"react": "18.3.1",
4646
"react-dom": "18.3.1",
4747
"rehype-pretty-code": "0.11.0",

packages/docs/src/repl/repl-output-update.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@ const deepUpdate = (prev: any, next: any) => {
1212
}
1313
}
1414
if (Array.isArray(prev)) {
15-
for (const key in prev) {
16-
if (!(key in next)) {
17-
delete prev[key];
18-
// deleting array elements doesn't change the length
19-
prev.length--;
15+
for (const item of prev) {
16+
if (!next.includes(item)) {
17+
prev.splice(prev.indexOf(item), 1);
2018
}
2119
}
2220
} else {

packages/qwik/src/core/shared/shared-serialization.unit.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ describe('shared-serialization', () => {
149149
it(title(TypeIds.Error), async () => {
150150
const err = new Error('hi');
151151
err.stack = err
152-
.stack!.replaceAll(/\/.*\./g, '/...path/file.')
152+
.stack!.replaceAll(/([A-Z]:){0,1}(\/|\\).*\./g, '/...path/file.')
153153
.replaceAll(/:\d+:\d+/g, ':123:456');
154154
expect(await dump(err)).toMatchInlineSnapshot(`
155155
"

packages/qwik/src/optimizer/core/src/inlined_fn.rs

-3
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ pub fn convert_inlined_fn(
4747
return (None, is_const);
4848
}
4949

50-
println!("{:?}", is_used_as_object(&expr, &scoped_idents));
51-
5250
if !is_used_as_object(&expr, &scoped_idents) {
5351
return (None, is_const);
5452
}
@@ -218,7 +216,6 @@ impl<'a> Visit for ObjectUsageChecker<'a> {
218216
if let ast::Expr::Ident(obj_ident) = &*node.obj {
219217
for id in self.identifiers {
220218
if obj_ident.sym == id.0 {
221-
println!("Used as object: {:?}", obj_ident.sym);
222219
self.used_as_object = true;
223220
return;
224221
}

pnpm-lock.yaml

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)