fix: flaky signal e2e test

Author: Varixo

Diff for: packages/qwik/src/core/shared/shared-serialization.ts

@@ -1296,7 +1296,7 @@ async function serialize(serializationContext: SerializationContext): Promise<vo
 
   function $resolvePromise$(
     promise: Promise<unknown>,
-    $addRoot$: (obj: unknown) => string | number,
+    $addRoot$: (obj: unknown) => number,
     classCreator: (resolved: boolean, resolvedValue: unknown) => PromiseResult
   ) {
     const forwardRefId = forwardRefsId++;
@@ -1315,44 +1315,50 @@ async function serialize(serializationContext: SerializationContext): Promise<vo
     return forwardRefId;
   }
 
-  $writer$.write('[');
+  const outputRoots = async () => {
+    $writer$.write('[');
 
-  let lastRootsLength = 0;
-  let rootsLength = serializationContext.$roots$.length;
-  while (lastRootsLength < rootsLength || promises.size) {
-    if (lastRootsLength !== 0) {
-      $writer$.write(',');
-    }
-    for (let i = lastRootsLength; i < rootsLength; i++) {
-      const root = serializationContext.$roots$[i];
-      writeValue(root);
-      const isLast = i === rootsLength - 1;
-      if (!isLast) {
+    let lastRootsLength = 0;
+    let rootsLength = serializationContext.$roots$.length;
+    while (lastRootsLength < rootsLength || promises.size) {
+      if (lastRootsLength !== 0) {
         $writer$.write(',');
       }
-    }
 
-    if (promises.size) {
-      try {
-        await Promise.race(promises);
-      } catch {
-        // ignore rejections, they will be serialized as rejected promises
+      let separator = false;
+      for (let i = lastRootsLength; i < rootsLength; i++) {
+        if (separator) {
+          $writer$.write(',');
+        } else {
+          separator = true;
+        }
+        writeValue(serializationContext.$roots$[i]);
+      }
+
+      if (promises.size) {
+        try {
+          await Promise.race(promises);
+        } catch {
+          // ignore rejections, they will be serialized as rejected promises
+        }
       }
+
+      lastRootsLength = rootsLength;
+      rootsLength = serializationContext.$roots$.length;
     }
 
-    lastRootsLength = rootsLength;
-    rootsLength = serializationContext.$roots$.length;
-  }
+    if (forwardRefs.length) {
+      $writer$.write(',');
+      $writer$.write(TypeIds.ForwardRefs + ',');
+      outputArray(forwardRefs, (value) => {
+        $writer$.write(String(value));
+      });
+    }
 
-  if (forwardRefs.length) {
-    $writer$.write(',');
-    $writer$.write(TypeIds.ForwardRefs + ',');
-    outputArray(forwardRefs, (value) => {
-      $writer$.write(String(value));
-    });
-  }
+    $writer$.write(']');
+  };
 
-  $writer$.write(']');
+  await outputRoots();
 }
 
 function $getCustomSerializerPromise$<T, S>(signal: SerializerSignalImpl<T, S>, value: any) {

Diff for: packages/qwik/src/core/shared/shared-serialization.unit.ts

@@ -447,7 +447,7 @@ describe('shared-serialization', () => {
           Constant null
         ]
         2 RootRef "1 1 0 0"
-        (96 chars)"
+        (88 chars)"
       `);
     });
     it(title(TypeIds.ComputedSignal), async () => {

Diff for: starters/e2e/e2e.signals.e2e.ts

@@ -464,6 +464,8 @@ test.describe("signals", () => {
       await expect(resultC).toHaveText("0:0");
       await expect(resultTotal).toHaveText("0:0");
 
+      await page.waitForLoadState("networkidle");
+
       await buttonA.click();
       await expect(resultA).toHaveText("1:1");
       await expect(resultB).toHaveText("0:0");