[🐞] custom service worker is not being built in 1.16.1

[makinghappen]

Which component is affected?

Qwik Runtime

Describe the bug

in 1.16.1 service-worker is not being built from custom src/routes/service-worker.ts
is present in src/root.tsx

in 1.15.0 everything works

this bug is a follow-up for #7856

Reproduction

https://stackblitz.com/edit/github-qakywqfa-oiqw7c51?file=src%2Froutes%2Fservice-worker.ts,src%2Froot.tsx

Steps to reproduce

No response

System Info

qwik 1.16.1

Additional Information

No response

[makinghappen]

I found that service worker is being generated in ./build/q-DDBBNvZq.js

import{_ as e}from"./q-DaBs9vqE.js";const _=()=>e(()=>import("./q-DDBBNvZq.js").then(r=>r.s),[]);export{_ as ServiceworkerServiceWorker};

but in ./build/index.html it is registered from /service-worker.js
<script type="module" q:key="ig_7" q:head>"serviceWorker"in navigator?(navigator.serviceWorker.register("/service-worker.js").catch(e=>console.error(e))...

[maiieul]

iirc you need to remove the <ServiceWorkerRegister> component from your root.tsx, but keep the service-worker.ts file in your routes dir. It's a bit confusing, but the alternatives weren't much better. Can you try with this and report back?

[maiieul]

iirc you need to remove the component from your root.tsx, but keep the service-worker.ts file in your routes dir. It's a bit confusing, but the alternatives weren't much better. Can you try with this and report back?

Hmmm actually I didn't recall correctly. The service worker should be unregistered only if you remove the service-worker.ts file(s) from your routes dir. Could you provide a gh repository repro? I don't know how it's supposed to work in stackblitz.

[maiieul]

Note: the service worker will only be added in preview/prod, not in dev. It's always been like that.

[makinghappen]

iirc you need to remove the <ServiceWorkerRegister> component from your root.tsx, but keep the service-worker.ts file in your routes dir. It's a bit confusing, but the alternatives weren't much better. Can you try with this and report back?

no, it is not being built this way too..

[maiieul]

Wait, even in preview/prod? I will need a gh repository repro to debug this.

[makinghappen]

@maiieul traced the root cause of the issue, in qwik app I am importing idb, and also using it in service worker, what causes the service worker to be built in dist/build/routes-service-worker.ts.js instead of dist/service-worker.js

here is a minimal Playground App (Qwik City + Qwik) opening IndexedDB and with service worker using IndexedDB demonstrating the issue:
https://github.com/makinghappen/qwik-sw-test

try building it with:
pnpm run build
and you will see that service worker is built incorrectly in dist/build

then remove getDB from router-head.tsx and service worker will be built successfully.

https://github.com/makinghappen/qwik-sw-test/blob/b287c6fbbe73cf568e1b48141a504fbbbae091b3/src/components/router-head/router-head.tsx#L15