[🐞] v2: qwik router `platform` option doesn't work

[wmertens]

Which component is affected?

Qwik City (routing)

Describe the bug

In v1 you can amend the request event platform in dev mode using the platform option. code

In v2 that doesn't happen. Should this be removed, or supported? In any case it will only work for in-process dev servers.

Reproduction

n/a

Steps to reproduce

No response

System Info

-

Additional Information

No response

[seanperez-xyz]

I mean what’s the point in even having the positional argument if it doesn’t do anything … it’s a dev thing I only use cloudflare so I don’t know the affect it has on other platforms”” or how other ones utilize that in dev…

In production build it works without the platform since it’s guarded by isDev or node env === “development”
So that guard plays no role in production and it works. But in development mode which is what I am seeing is Vite dev or npm run dev runs off vite dev servers or entry, at that point it fails since “platform” doesn’t populate you can add it but it doesn’t populate the rest of the project … it’s just a dev thing doesn’t play any role in production Atleast from the entry file for cloudflare … the adapter file I added the env as per how cloudflare create has it, so the types are correct with in the dev Env as well . But the platform doesn’t populate. Work around was to put the getPlatFormProxy() in the middleware for example.

Routes/001-db.ts -> put here as an optional isDev ? getPlatformProxy() : platform.env
But that’s a patch so if you have another middleware

Routes/002-auth.ts that uses platform.env ( if your using the DB adapter or for the Env vars for secret or GitHub Google ID SECRET etc … platform.env.AUTH_SECRET …
It works in production but in dev the platform never populates… so fix or workaround is using isDev ? Import.meta.env.AUTH _SECRET : platform.env.AUTH_SECRET ….
Granted that can probably be avoided by just using the .env or meta way still shows a potential breaking change.

It’s great that it still works in production but we are devs… can’t dev without having to dev first …

Yes wrangler pages dev kind of works ? But I think you need to build first so /dist is available but so far that only works on Mac I have never got npm run serve ( with cf adapter ) to work on windows in v1 or v2 (v1 successfully builds, v2 fails to build unless in WSL )

If platform positional isn’t doing anything then remove it so it throws an error in lint , or let it work the same as before, otherwise you migrate add it throws no errors then you got to dig around why it not working … currently it throws no errors cus it’s still there and properly typed . It just doesn’t populate the rest of the project (as per the link ref above.)

[wmertens]

@seanperez-xyz I think this is solved now, can you try with the nightly builds? #6903 (comment)