new error in use_DRAC() due to DRAC changes

[mcol]

The following error is making this test fail:

input <- template_DRAC(preset = "DRAC-example_quartz")
input$`Project ID` <- "DRAC-Example"
input$`Sample ID` <- "Quartz"
input$`Conversion factors` <- "AdamiecAitken1998"
input$`External U (ppm)` <- 3.4
input$`errExternal U (ppm)` <- 0.51
input$`External Th (ppm)` <- 14.47
input$`errExternal Th (ppm)` <- 1.69
input$`External K (%)` <- 1.2
input$`errExternal K (%)` <- 0.14
input$`Calculate external Rb from K conc?` <- "Y"
input$`Calculate internal Rb from K conc?` <- "Y"
input$`Scale gammadoserate at shallow depths?` <- "Y"
input$`Grain size min (microns)` <- 90L
input$`Grain size max (microns)` <- 125L
input$`Water content ((wet weight - dry weight)/dry weight) %` <- 5
input$`errWater content %` <- 2
input$`Depth (m)` <- 2.2
input$`errDepth (m)` <- 0.22
input$`Overburden density (g cm-3)` <- 1.8
input$`errOverburden density (g cm-3)` <- 0.1
input$`Latitude (decimal degrees)` <- 30.0000
input$`Longitude (decimal degrees)` <- 70.0000
input$`Altitude (m)` <- 150
input$`De (Gy)` <- 20
input$`errDe (Gy)` <- 0.2
use_DRAC(input)

# Error: [use_DRAC()]
#	 We got a response from the server, but it
#	 did not contain DRAC output. Please check
#	 your data and verify its validity.

Looking at the response, it looks like this, which suggests that the DRAC backend has somewhat changed:

<b>Deprecated</b>:  Creation of dynamic property Drac::$data is deprecated in <b>/webfs/drcwww/devel/calculator/drac.php</b> on line <b>16</b><br />
<br />
<b>Deprecated</b>:  Creation of dynamic property Drac::$output_file_name is deprecated in <b>/webfs/drcwww/devel/calculator/drac.php</b> on line <b>19</b><br />
<br />
<b>Fatal error</b>:  Uncaught TypeError: Unsupported operand types: string * float in /webfs/drcwww/devel/calculator/outputs.php:239
Stack trace:
#0 /webfs/drcwww/devel/calculator/output_helpers.php(132): {closure}()
#1 /webfs/drcwww/devel/calculator/outputs.php(769): VALUE()
#2 /webfs/drcwww/devel/calculator/output_helpers.php(132): {closure}()
#3 /webfs/drcwww/devel/calculator/outputs.php(1370): VALUE()
#4 /webfs/drcwww/devel/calculator/output_helpers.php(132): {closure}()
#5 /webfs/drcwww/devel/calculator/drac.php(120): VALUE()
#6 /webfs/drcwww/devel/main/drac-init.php(27): Drac-&gt;run_calc()
#7 /webfs/drcwww/devel/index.php(6): require_once('...')
#8 {main}
  thrown in <b>/webfs/drcwww/devel/calculator/outputs.php</b> on line <b>239</b><br />

[RLumSK]

I've just tried the "normal" web interface, this seems to still work as expected:

https://www.aber.ac.uk/en/dges/research/quaternary/luminescence-research-laboratory/dose-rate-calculator/

[mcol]

I've had a look at this again, and narrowed down the problem to just one line of input:

input$`Calculate internal Rb from K conc?` <- "Y"

If I comment that out, the rest of the test works.

[mcol]

I've tried again with the problematic input and it still fails. Status code 500 corresponds to internal server error:

Error: [use_DRAC()] Transmission failed with HTTP status code: 500

[mcol]

It turns out that when we set input$"Calculate internal Rb from K conc?" <- "Y" (TI:22), we trigger a bit of code in the DRAC calculator that checks for variable TI:18:
https://github.com/geoffLumin/DRAC-calculator/blob/d9ea75d3b047866480c0d5f6874190898e81e5d1/calculator/outputs.php#L225-L230

However, our setting for the TI:18 input (Internal K (%)) is wrong:

Luminescence/R/template_DRAC.R

Lines 232 to 234 in 05f8948

	`Internal K (%)` =
	structure(rep(NA_real_, nrow), required = FALSE, allowsX = TRUE, default_class = "numeric", key = "TI:18",
	description = "Internal radionuclide concentrations in parts per million for Uranium, Thorium and Rubidium and % for Potassium. Inputs must be 0 or positive and should not be left blank."), #

The description says "Inputs must be 0 or positive and should not be left blank" but we set allowsX = TRUE, which is wrong and causes the error reported above.

[mcol]

The patch in #1234 revealed that this would be enough to fix the 500 error with the example dataset, but after reviewing the template_DRAC() code (and some of inputs.php and outputs.php of DRAC itself) I don't think that it's the correct approach.

I now think that "should not be left blank" is associated with the required field, not with allowsX. If that's correct, then the bug is really in DRAC, where this check should say !valid_blank( $i['TI:18'] ) || $i['TI:18'] == 0.