Skip to content

Commit 988ab97

Browse files
committed
ci: clarify TODO for trusted publishing environments
1 parent 2db3919 commit 988ab97

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.github/workflows/marketplace-pre-release.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
prerelease-date: ${{ needs.prepare.outputs.date }}
4141

4242
publish-vs-marketplace:
43-
# TODO: Uncomment after a repository admin creates the vs-marketplace environment (for trusted publishing) and moves VSCE_TOKEN into it.
43+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the vs-marketplace environment first.
4444
# environment: vs-marketplace
4545
needs:
4646
- prepare
@@ -73,7 +73,7 @@ jobs:
7373
run: pnpm exec vsce publish --pre-release --skip-duplicate --packagePath artifacts/vscode-R.vsix
7474

7575
publish-open-vsx:
76-
# TODO: Uncomment after a repository admin creates the open-vsx environment (for trusted publishing) and moves OPEN_VSX_TOKEN into it.
76+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the open-vsx environment first.
7777
# environment: open-vsx
7878
needs:
7979
- prepare

‎.github/workflows/release.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
6262
publish-vs-marketplace:
6363
name: Publish to Visual Studio Marketplace
64-
# TODO: Uncomment after a repository admin creates the vs-marketplace environment (for trusted publishing) and moves VSCE_TOKEN into it.
64+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the vs-marketplace environment first.
6565
# environment: vs-marketplace
6666
timeout-minutes: 30
6767
runs-on: ubuntu-latest
@@ -86,7 +86,7 @@ jobs:
8686

8787
publish-open-vsx:
8888
name: Publish to Open VSX Registry
89-
# TODO: Uncomment after a repository admin creates the open-vsx environment (for trusted publishing) and moves OPEN_VSX_TOKEN into it.
89+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the open-vsx environment first.
9090
# environment: open-vsx
9191
timeout-minutes: 30
9292
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)