Skip to content

Commit e38a189

Browse files
committed
ci: note trusted publishing constraints in environment TODOs
1 parent bbab8f4 commit e38a189

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

‎.github/workflows/marketplace-pre-release.yml‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ jobs:
4040
prerelease-date: ${{ needs.prepare.outputs.date }}
4141

4242
publish-vs-marketplace:
43-
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the vs-marketplace environment first.
43+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token).
44+
# A repository admin must create the vs-marketplace environment, and each
45+
# publishing workflow file needs its own Marketplace trusted publishing policy.
4446
# environment: vs-marketplace
4547
needs:
4648
- prepare
@@ -73,7 +75,11 @@ jobs:
7375
run: pnpm exec vsce publish --pre-release --skip-duplicate --packagePath artifacts/vscode-R.vsix
7476

7577
publish-open-vsx:
76-
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the open-vsx environment first.
78+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token).
79+
# A repository admin must create the open-vsx environment. Open VSX may allow
80+
# only one trusted publisher per extension, so stable and pre-release
81+
# publishing may first need to be consolidated into a single workflow file
82+
# (a shared reusable workflow may not be enough, since the caller differs).
7783
# environment: open-vsx
7884
needs:
7985
- prepare

‎.github/workflows/release.yml‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ jobs:
6565
6666
publish-vs-marketplace:
6767
name: Publish to Visual Studio Marketplace
68-
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the vs-marketplace environment first.
68+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token).
69+
# A repository admin must create the vs-marketplace environment, and each
70+
# publishing workflow file needs its own Marketplace trusted publishing policy.
6971
# environment: vs-marketplace
7072
timeout-minutes: 30
7173
runs-on: ubuntu-latest
@@ -90,7 +92,11 @@ jobs:
9092

9193
publish-open-vsx:
9294
name: Publish to Open VSX Registry
93-
# TODO: Uncomment when switching to trusted publishing (OIDC, no token); a repository admin must create the open-vsx environment first.
95+
# TODO: Uncomment when switching to trusted publishing (OIDC, no token).
96+
# A repository admin must create the open-vsx environment. Open VSX may allow
97+
# only one trusted publisher per extension, so stable and pre-release
98+
# publishing may first need to be consolidated into a single workflow file
99+
# (a shared reusable workflow may not be enough, since the caller differs).
94100
# environment: open-vsx
95101
timeout-minutes: 30
96102
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)