Skip to content

Commit f00399e

Browse files
chore: bump sinon and @types/sinon (#1918)
* chore: bump sinon and @types/sinon Bumps [sinon](https://github.com/sinonjs/sinon) and [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon). These dependencies needed to be updated together. Updates `sinon` from 15.2.0 to 22.1.0 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/CHANGES.md) - [Commits](sinonjs/sinon@v15.2.0...v22.1.0) Updates `@types/sinon` from 10.0.20 to 22.0.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) --- updated-dependencies: - dependency-name: "@types/sinon" dependency-version: 22.0.1 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: sinon dependency-version: 22.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * test: keep viewer polling clocks out of session teardown --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kun Ren <renkun@outlook.com>
1 parent 8f201e8 commit f00399e

3 files changed

Lines changed: 25 additions & 73 deletions

File tree

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2621,7 +2621,7 @@
26212621
"@types/ejs": "^3.1.5",
26222622
"@types/mocha": "^8.2.3",
26232623
"@types/node": "^22.20.5",
2624-
"@types/sinon": "^10.0.20",
2624+
"@types/sinon": "^22.0.2",
26252625
"@types/vscode": "~1.101.0",
26262626
"@types/winreg": "^1.2.36",
26272627
"@vscode/test-cli": "^0.0.15",
@@ -2633,7 +2633,7 @@
26332633
"mocha": "^12.0.3",
26342634
"ovsx": "^1.3.0",
26352635
"oxfmt": "0.73.0",
2636-
"sinon": "^15.2.0",
2636+
"sinon": "^22.1.0",
26372637
"typescript": "~7.0.2",
26382638
"oxlint": "^1.89.0",
26392639
"oxlint-tsgolint": "~7.0.2005"

‎pnpm-lock.yaml‎

Lines changed: 20 additions & 70 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/test/suite/dataViewerSessions.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,8 @@ suite('Viewer session ownership', () => {
589589
});
590590

591591
test('viewers share polling and release it when the last viewer closes', async () => {
592-
const clock = sandbox.useFakeTimers();
592+
// Server shutdown needs real nextTick callbacks; only fake the polling interval.
593+
const clock = sandbox.useFakeTimers({ toFake: ['setInterval', 'clearInterval'] });
593594
const kill = sandbox.stub(process, 'kill').returns(true);
594595
const request = sandbox.stub().resolves({});
595596
const first = session.registerSessionTransport(
@@ -663,6 +664,7 @@ suite('Viewer session ownership', () => {
663664
} finally {
664665
session.unregisterSessionTransport(first);
665666
session.unregisterSessionTransport(second);
667+
clock.restore();
666668
}
667669
});
668670

0 commit comments

Comments
 (0)