Skip to content

Commit e338d74

Browse files
authored
Merge pull request #69 from itaru2622/issue68
support optional_fields on getting meta data of probe / measurement
2 parents 4bbcf4b + a3074b8 commit e338d74

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

ripe/atlas/cousteau/api_meta_data.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,15 @@ def __init__(self, **kwargs):
3535
self.meta_data = kwargs.get("meta_data")
3636
self._user_agent = kwargs.get("user_agent")
3737
self._fields = kwargs.get("fields")
38+
self._optional_fields = kwargs.get("optional_fields")
3839
self.get_params = {}
3940

4041
if self.meta_data is None and self.id is None:
4142
raise CousteauGenericError(
4243
"Id or meta_data should be passed in order to create object."
4344
)
4445

45-
if self._fields:
46+
if self._fields or self._optional_fields:
4647
self.update_get_params()
4748

4849
if self.meta_data is None:
@@ -58,6 +59,11 @@ def update_get_params(self):
5859
elif isinstance(self._fields, str):
5960
self.get_params["fields"] = self._fields
6061

62+
if isinstance(self._optional_fields, (tuple, list)): # tuples & lists > x,y,z
63+
self.get_params["optional_fields"] = ",".join([str(_) for _ in self._optional_fields])
64+
elif isinstance(self._optional_fields, str):
65+
self.get_params["optional_fields"] = self._optional_fields
66+
6167
def _fetch_meta_data(self):
6268
"""Makes an API call to fetch meta data for the given probe and stores the raw data."""
6369
is_success, meta_data = AtlasRequest(

0 commit comments

Comments
 (0)