Merge branch 'main' into feature/actuallytaylor/timer_refactor

Author: ActuallyTaylor

include/core/manager.hpp

@@ -223,7 +223,7 @@ GPIO& getGPIO(GPIO::Direction direction = GPIO::Direction::OUTPUT, GPIO::Pull pu
     return gpioPin;
     #endif
     #ifdef STM32F4xx
-    static GPIOf4xx gpioPin(pin, direction);
+    static GPIOf4xx gpioPin(pin, direction, pull);
     return gpioPin;
     #endif
 }

src/core/io/platform/f3xx/GPIOf3xx.cpp

@@ -118,7 +118,7 @@ void GPIOf3xx::registerIRQ(TriggerEdge edge, void (*irqHandler)(GPIO* pin, void*
                   myPins,
                   numOfPins,
                   GPIOf3xx::GPIO_TRIGGER_INTERRUPT_BASE | (static_cast<uint32_t>(edge) << GPIO_MODE_IT_SHIFT),
-                  GPIO_PULLDOWN,
+                  static_cast<uint32_t>(pull),
                   GPIO_SPEED_FREQ_HIGH);
 
     auto pin_index                = static_cast<uint8_t>(this->pin) & 0x0F;

src/core/io/platform/f4xx/GPIOf4xx.cpp

@@ -69,7 +69,6 @@ GPIOf4xx::GPIOf4xx(Pin pin, GPIO::Direction direction, Pull pull) : GPIO(pin, di
                   numOfPins,
                   static_cast<uint32_t>(direction),
                   static_cast<uint32_t>(pull),
-                  GPIO_PULLDOWN,
                   GPIO_SPEED_FREQ_HIGH);
 
     // TODO: double check that this actually applies to F4xx the same way it does to F3xx
@@ -118,7 +117,7 @@ void GPIOf4xx::registerIRQ(TriggerEdge edge, void (*irqHandler)(GPIO* pin, void*
                   myPins,
                   numOfPins,
                   GPIOf4xx::GPIO_TRIGGER_INTERRUPT_BASE | (static_cast<uint32_t>(edge) << GPIO_MODE_IT_SHIFT),
-                  GPIO_PULLDOWN,
+                  static_cast<uint32_t>(pull),
                   GPIO_SPEED_FREQ_HIGH);
 
     auto pin_index                = static_cast<uint8_t>(this->pin) & 0x0F;