ci: Gate Windows hip-tests ROCR job behind opt-in flag (#4878)

Add a WINDOWS_HIP_ROCR_TESTS CI flag to control whether the Windows
hip-tests (ROCR) matrix entry is emitted. Windows hip-tests (PAL) remains
enabled by default, while ROCR coverage can be opted into through the new
windows_hip_rocr_tests workflow input.

Update fetch_test_configurations.py to read the flag, wire the input through
test_artifacts.yml, and adjust tests so the default path emits PAL only while
ROCR-specific cases opt in explicitly.

This keeps current callers unaffected while preserving a temporary path for
ROCR parity tracking until issue #3587 is resolved.

Author: jayhawk-commits

.github/workflows/test_artifacts.yml

@@ -31,6 +31,9 @@ on:
       run_extended_tests:
         type: string
         default: 'false'
+      windows_hip_rocr_tests:
+        type: string
+        default: 'false'
       release_type:
         description: 'Release type: "" for CI, or "dev", "nightly", "prerelease".'
         type: string
@@ -62,6 +65,9 @@ on:
       run_extended_tests:
         type: string
         default: 'false'
+      windows_hip_rocr_tests:
+        type: string
+        default: 'false'
       release_type:
         type: string
         default: ""
@@ -114,6 +120,7 @@ jobs:
           TEST_TYPE: ${{ inputs.test_type }}
           TEST_LABELS: ${{ inputs.test_labels }}
           RUN_EXTENDED_TESTS: ${{ inputs.run_extended_tests }}
+          WINDOWS_HIP_ROCR_TESTS: ${{ inputs.windows_hip_rocr_tests }}
         run: python ./build_tools/github_actions/fetch_test_configurations.py
 
   test_sanity_check:

build_tools/github_actions/fetch_test_configurations.py

@@ -573,6 +573,7 @@ def run():
     test_type = os.getenv("TEST_TYPE", "full")
     test_labels = ast.literal_eval(os.getenv("TEST_LABELS") or "[]")
     run_extended_tests = str2bool(os.getenv("RUN_EXTENDED_TESTS", "false"))
+    windows_hip_rocr_tests = str2bool(os.getenv("WINDOWS_HIP_ROCR_TESTS", "false"))
 
     logging.info(f"Selecting projects: {projects_to_test}")
 
@@ -631,9 +632,9 @@ def run():
         ):
             logging.info(f"Including job {job_name} with test_type {test_type}")
 
-            # Hip-tests on Windows run twice: PAL (pass/fail) and ROCR (informational)
-            # for parity tracking until ROCR is the pass/fail path. See:
-            # https://github.com/ROCm/TheRock/issues/3587
+            # Hip-tests on Windows: always run PAL (pass/fail). Optionally also run
+            # ROCR (informational) for parity tracking when WINDOWS_HIP_ROCR_TESTS=true.
+            # See: https://github.com/ROCm/TheRock/issues/3587
             if key == "hip-tests" and platform == "windows":
                 base = selected_matrix[key]
                 total_shards = base.get("total_shards_dict", {}).get(platform, 1)
@@ -654,19 +655,20 @@ def run():
                 }
                 all_components.append(pal_entry)
 
-                rocr_entry = {
-                    "job_name": "hip-tests (ROCR)",
-                    "fetch_artifact_args": base["fetch_artifact_args"],
-                    "timeout_minutes": base["timeout_minutes"],
-                    "test_script": base["test_script"],
-                    "platform": base["platform"],
-                    "total_shards": total_shards,
-                    "test_type": test_type,
-                    "shard_arr": shard_arr,
-                    "expect_failure": True,
-                    "gpu_enable_pal": "0",
-                }
-                all_components.append(rocr_entry)
+                if windows_hip_rocr_tests:
+                    rocr_entry = {
+                        "job_name": "hip-tests (ROCR)",
+                        "fetch_artifact_args": base["fetch_artifact_args"],
+                        "timeout_minutes": base["timeout_minutes"],
+                        "test_script": base["test_script"],
+                        "platform": base["platform"],
+                        "total_shards": total_shards,
+                        "test_type": test_type,
+                        "shard_arr": shard_arr,
+                        "expect_failure": True,
+                        "gpu_enable_pal": "0",
+                    }
+                    all_components.append(rocr_entry)
                 continue
 
             job_config_data = selected_matrix[key]

build_tools/github_actions/tests/fetch_test_configurations_test.py

@@ -267,10 +267,26 @@ def fake_get_all_families(_):
     # Output contract
     # -----------------------
 
+    def test_windows_hip_tests_default_emits_pal_only(self):
+        """On Windows, hip-tests emits only PAL by default (WINDOWS_HIP_ROCR_TESTS off)."""
+        os.environ["RUNNER_OS"] = "Windows"
+        os.environ["TEST_LABELS"] = json.dumps(["hip-tests"])
+
+        fetch_test_configurations.run()
+        components = self._get_components()
+
+        hip_jobs = [j for j in components if "hip-tests" in j["job_name"]]
+        self.assertEqual(len(hip_jobs), 1, "Expected only hip-tests (PAL)")
+        self.assertEqual(hip_jobs[0]["job_name"], "hip-tests (PAL)")
+        self.assertNotIn("expect_failure", hip_jobs[0])
+        self.assertEqual(hip_jobs[0]["total_shards"], 4)
+        self.assertEqual(hip_jobs[0]["shard_arr"], [1, 2, 3, 4])
+
     def test_windows_hip_tests_emits_pal_and_rocr_entries(self):
-        """On Windows, hip-tests run twice: PAL (pass/fail) and ROCR (informational)."""
+        """On Windows with WINDOWS_HIP_ROCR_TESTS=true, hip-tests runs PAL and ROCR."""
         os.environ["RUNNER_OS"] = "Windows"
         os.environ["TEST_LABELS"] = json.dumps(["hip-tests"])
+        os.environ["WINDOWS_HIP_ROCR_TESTS"] = "true"
 
         fetch_test_configurations.run()
         components = self._get_components()
@@ -293,10 +309,11 @@ def test_windows_hip_tests_emits_pal_and_rocr_entries(self):
         self.assertEqual(rocr["shard_arr"], [1, 2, 3, 4])
 
     def test_windows_hip_tests_quick_uses_single_shard(self):
-        """On Windows with test_type=quick, hip-tests PAL/ROCR each use 1 shard."""
+        """On Windows with test_type=quick and ROCR enabled, PAL/ROCR each use 1 shard."""
         os.environ["RUNNER_OS"] = "Windows"
         os.environ["TEST_LABELS"] = json.dumps(["hip-tests"])
         os.environ["TEST_TYPE"] = "quick"
+        os.environ["WINDOWS_HIP_ROCR_TESTS"] = "true"
 
         fetch_test_configurations.run()
         components = self._get_components()