Skip to content

Commit 4c946a9

Browse files
committed
Rename install_requirements.py, changed additional_requirements_files to array, add build test flag
1 parent 35c6726 commit 4c946a9

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

.github/workflows/test_component.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,11 @@ jobs:
128128
run: |
129129
python ./build_tools/print_driver_gpu_info.py
130130
131-
- name: Setup Requirements
131+
- name: Setup Additional Requirements
132+
if: ${{ fromJSON(inputs.component).additional_requirements_files != '' }}
132133
run: |
133-
python ./build_tools/install_requirements.py \
134-
--requirements-files=${{ fromJSON(inputs.component).requirements_files }}
134+
python ./build_tools/install_additional_requirements.py \
135+
--requirements-files=${{ fromJSON(inputs.component).additional_requirements_files }}
135136
136137
- name: Test
137138
timeout-minutes: ${{ fromJSON(inputs.component).timeout_minutes }}

build_tools/github_actions/fetch_test_configurations.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,10 @@ def _get_script_path(script_name: str) -> str:
306306
"job_name": "rocprofiler_compute",
307307
"fetch_artifact_args": "--rocprofiler-compute --rocprofiler-sdk --tests",
308308
"timeout_minutes": 60,
309-
"requirements_files": "libexec/rocprofiler-compute/requirements.txt,libexec/rocprofiler-compute/requirements-test.txt",
309+
"requirements_files": [
310+
"libexec/rocprofiler-compute/requirements.txt",
311+
"libexec/rocprofiler-compute/requirements-test.txt",
312+
],
310313
"test_script": f"python {_get_script_path('test_rocprofiler_compute.py')} -v",
311314
"platform": ["linux"],
312315
"total_shards": 2,
File renamed without changes.

profiler/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@ endif(THEROCK_BUILD_TESTING)
125125
gfx942
126126
CMAKE_ARGS
127127
-DHIP_PLATFORM=amd
128-
-DENABLE_TESTS=ON
129-
-DINSTALL_TESTS=ON
130-
-DTEST_FROM_INSTALL=ON
128+
-DBUILD_TEST=${THEROCK_BUILD_TESTING}
129+
-DINSTALL_TESTS=${THEROCK_BUILD_TESTING}
130+
-DTEST_FROM_INSTALL=${THEROCK_BUILD_TESTING}
131131
-DCHECK_PYTHON_DEPS=OFF
132132
CMAKE_INCLUDES
133133
therock_explicit_finders.cmake

0 commit comments

Comments
 (0)