Skip to content

Commit 62ceb17

Browse files
committed
Update review comments - modified required flags, comments cleanup
1 parent d351008 commit 62ceb17

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

build_tools/packaging/linux/native_linux_packages_test.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323
- System packages: python3, pip, wget, curl; pip packages: pyelftools, requests,
2424
prettytable, PyYAML.
2525
26-
Supports both nightly and prerelease builds:
27-
- Nightly: https://rocm.nightlies.amd.com/
28-
- Prerelease: https://rocm.prereleases.amd.com/packages/
29-
3026
Example invocations:
3127
3228
# Nightly DEB (Ubuntu 24.04) - run inside ubuntu:24.04 container or VM
@@ -171,12 +167,6 @@ def __init__(
171167
f"amdrocm-core-sdk-{self.gfx_arch}",
172168
]
173169

174-
# Validate inputs
175-
if self.release_type not in ["nightly", "prerelease"]:
176-
raise ValueError(
177-
f"Invalid release type: {release_type}. Must be 'nightly' or 'prerelease'"
178-
)
179-
180170
def setup_gpg_key(self) -> bool:
181171
"""Setup GPG key for repositories that require GPG verification.
182172
@@ -967,15 +957,13 @@ def main():
967957
parser.add_argument(
968958
"--release-type",
969959
type=str,
970-
required=True,
971960
choices=["nightly", "prerelease"],
972961
help="Type of release: 'nightly' or 'prerelease'",
973962
)
974963

975964
parser.add_argument(
976965
"--install-prefix",
977966
type=str,
978-
required=True,
979967
help="Installation prefix (e.g. /opt/rocm/core)",
980968
)
981969

0 commit comments

Comments
 (0)