Commit 8d042a2
authored
## Motivation
Multi-arch CI is now enabled by default in TheRock, so we should make
the default for developers match what CI is doing.
See:
* #3337
* iree-org/fusilli#57
* ROCm/rocm-libraries#6903
## Technical Details
* This will add 45s+ to initial clone time when using the legacy fetch
options.
* Repositories that have not yet migrated to the `--stage` mode of
fetching sources will pay this extra cost if they don't explicitly
opt-out of the new setting.
* This will enable a few new subproject builds (IREE's LLVM, fusilli,
etc.) by default which are already enabled for multi-arch CI.
* Repositories that have not yet migrated to multi-arch CI may want to
opt-out with `-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_*=ON` for some
subset (as rocm-libraries already does) or
`-DTHEROCK_ENABLE_IREE_LIBS=OFF`
* The `iree-compiler` artifact is still annotated with
`disable_platforms = ["windows"]` in `BUILD_TOPOLOGY.toml`, so the
builds remain disabled there
## Test Plan
* Multi-arch CI on this PR
* Non-multi-arch CI on this PR (watch fetch time and build time, see how
non-multi-arch CI in other repositories may want to adapt)
* https://github.com/ROCm/TheRock/actions/runs/25464273855?pr=5093
*
https://therock-ci-artifacts-external.s3.amazonaws.com/ROCm-TheRock/25464273855-linux/logs/gfx94X-dcgpu/index.html
*
https://therock-ci-artifacts-external.s3.amazonaws.com/ROCm-TheRock/25464273855-linux/logs/gfx94X-dcgpu/iree-compiler_build.log
(~5 minutes to build iree-compiler)
## Submission Checklist
- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 parent 360c975 commit 8d042a2
2 files changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
| 251 | + | |
251 | 252 | | |
252 | 253 | | |
253 | | - | |
254 | | - | |
255 | 254 | | |
256 | 255 | | |
257 | 256 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
886 | 886 | | |
887 | 887 | | |
888 | 888 | | |
889 | | - | |
| 889 | + | |
890 | 890 | | |
891 | 891 | | |
892 | 892 | | |
| |||
0 commit comments