Skip to content

Commit 8d042a2

Browse files
authored
Enable --include-iree-libs fetch and -DTHEROCK_ENABLE_IREE_LIBS build by default (#5093)
## Motivation Multi-arch CI is now enabled by default in TheRock, so we should make the default for developers match what CI is doing. See: * #3337 * iree-org/fusilli#57 * ROCm/rocm-libraries#6903 ## Technical Details * This will add 45s+ to initial clone time when using the legacy fetch options. * Repositories that have not yet migrated to the `--stage` mode of fetching sources will pay this extra cost if they don't explicitly opt-out of the new setting. * This will enable a few new subproject builds (IREE's LLVM, fusilli, etc.) by default which are already enabled for multi-arch CI. * Repositories that have not yet migrated to multi-arch CI may want to opt-out with `-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_*=ON` for some subset (as rocm-libraries already does) or `-DTHEROCK_ENABLE_IREE_LIBS=OFF` * The `iree-compiler` artifact is still annotated with `disable_platforms = ["windows"]` in `BUILD_TOPOLOGY.toml`, so the builds remain disabled there ## Test Plan * Multi-arch CI on this PR * Non-multi-arch CI on this PR (watch fetch time and build time, see how non-multi-arch CI in other repositories may want to adapt) * https://github.com/ROCm/TheRock/actions/runs/25464273855?pr=5093 * https://therock-ci-artifacts-external.s3.amazonaws.com/ROCm-TheRock/25464273855-linux/logs/gfx94X-dcgpu/index.html * https://therock-ci-artifacts-external.s3.amazonaws.com/ROCm-TheRock/25464273855-linux/logs/gfx94X-dcgpu/iree-compiler_build.log (~5 minutes to build iree-compiler) ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 parent 360c975 commit 8d042a2

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,9 @@ option(THEROCK_ENABLE_ML_LIBS "Enable building of ML libraries" "${THEROCK_ENABL
248248
option(THEROCK_ENABLE_PROFILER "Enable building the profiler libraries" "${THEROCK_ENABLE_ALL}")
249249
option(THEROCK_ENABLE_DC_TOOLS "Enable building of data center tools" "${THEROCK_ENABLE_ALL}")
250250
option(THEROCK_ENABLE_MEDIA_LIBS "Enable building of Media libraries" "${THEROCK_ENABLE_ALL}")
251+
option(THEROCK_ENABLE_IREE_LIBS "Enable building of IREE libraries" "${THEROCK_ENABLE_ALL}")
251252
option(THEROCK_ENABLE_HOST_MATH "Build all bundled host math libraries by default" OFF)
252253
option(THEROCK_RESET_FEATURES "One-shot flag which forces all feature flags to their default state for this configuration run" OFF)
253-
# TODO(iree-org/fusilli/issues/57): Enable fusilli build once multi-arch support lands.
254-
option(THEROCK_ENABLE_IREE_LIBS "Enable building of IREE libraries" OFF)
255254

256255
################################################################################
257256
# Artifact-based features are auto-generated from BUILD_TOPOLOGY.toml

build_tools/fetch_sources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -886,7 +886,7 @@ def main(argv):
886886
)
887887
parser.add_argument(
888888
"--include-iree-libs",
889-
default=False,
889+
default=True,
890890
action=argparse.BooleanOptionalAction,
891891
help="Include IREE and related libraries",
892892
)

0 commit comments

Comments
 (0)