[Comgr] Port isa_name_parsing_test to LIT and add SPIR-V identifier coverage

Ported isa_name_parsing_test from CTest to LIT. Adjusted CMakeList.txt files appropriately.

Author: theSK2005

amd/comgr/src/comgr.cpp

@@ -248,15 +248,6 @@ amd_comgr_status_t COMGR::parseTargetIdentifier(StringRef IdentStr,
   Ident.Features.erase(Ident.Features.begin());
 
 
-  // TODO: Add a LIT test for this
-  if (IdentStr == "spirv64-amd-amdhsa--amdgcnspirv" ||
-      IdentStr == "spirv64-amd-amdhsa-unknown-amdgcnspirv") {
-    // Features not supported for SPIR-V
-    if (!Ident.Features.empty())
-      return AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT;
-    return AMD_COMGR_STATUS_SUCCESS;
-  }
-
   size_t IsaIndex;
   amd_comgr_status_t Status = metadata::getIsaIndex(IdentStr, IsaIndex);
   if (Status != AMD_COMGR_STATUS_SUCCESS) {

amd/comgr/test-lit/CMakeLists.txt

@@ -54,5 +54,6 @@ add_comgr_lit_binary(status-string c)
 add_comgr_lit_binary(data-action c)
 add_comgr_lit_binary(lookup-code-object c)
 add_comgr_lit_binary(hotswap-rewrite c)
+add_comgr_lit_binary(parse-isa-name c)
 
 add_dependencies(check-comgr test-lit)

amd/comgr/test-lit/comgr-sources/parse-isa-name.c

@@ -0,0 +1,30 @@
+//===- parse-isa-name.c ------------------------------------------------------===//
+//
+// Part of Comgr, under the Apache License v2.0 with LLVM Exceptions. See
+// amd/comgr/LICENSE.TXT in this repository for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "amd_comgr.h"
+#include "common.h"
+
+int main(int argc, char *argv[]) {
+  amd_comgr_action_info_t DataAction;
+  amd_comgr_status_t Status;
+  const char *reason = "";
+
+  if (argc != 3) {
+    fprintf(stderr, "Usage: parse-isa-name <isa-name> <expected-status>\n");
+    exit(1);
+  }
+  amd_comgr_(create_action_info(&DataAction));
+  Status = amd_comgr_action_info_set_isa_name(DataAction, argv[1]);
+  amd_comgr_status_string(Status, &reason);
+  if (strcmp(reason, argv[2])) {
+    fail("INVALID: %s\n", reason);
+  }
+  else
+    printf("OK\n");
+  return 0;
+}

amd/comgr/test-lit/parse-isa-name.c

@@ -0,0 +1,27 @@
+// COM: Test Comgr parse-isa-name() API
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx803" SUCCESS
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx803" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx801:xnack+" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx801:xnack-" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx908:sramecc+" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx908:sramecc-" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx908:xnack+:sramecc+" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx908:xnack-:sramecc+" SUCCESS 
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx908:xnack-:sramecc-" SUCCESS 
+// RUN: parse-isa-name "spir64-amd-amdhsa--amdgcnspirv" SUCCESS 
+// RUN: parse-isa-name "spir64-amd-amdhsa-unknown-amdgcnspirv" SUCCESS 
+
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx1010:xnack+" SUCCESS 
+// RUN: parse-isa-name "" SUCCESS 
+
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx801:xnack+:sramecc+" INVALID_ARGUMENT
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx803:::" INVALID_ARGUMENT
+// RUN: parse-isa-name "amdgcn-amd-amdhsa-opencl-gfx803" INVALID_ARGUMENT
+// RUN: parse-isa-name "amdgcn-amd-amdhsa-gfx803" INVALID_ARGUMENT
+// RUN: parse-isa-name "gfx803" INVALID_ARGUMENT
+// RUN: parse-isa-name " amdgcn-amd-amdhsa--gfx803" INVALID_ARGUMENT
+// RUN: parse-isa-name " amdgcn-amd-amdhsa--gfx803 " INVALID_ARGUMENT
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx803 " INVALID_ARGUMENT
+// RUN: parse-isa-name "   amdgcn-amd-amdhsa--gfx803  " INVALID_ARGUMENT
+// RUN: parse-isa-name "amdgcn-amd-amdhsa--gfx803  " INVALID_ARGUMENT
+// RUN: parse-isa-name "spirv64-amd-amdhsa--amdgcnspirv:xnack+" INVALID_ARGUMENT

amd/comgr/test/CMakeLists.txt

@@ -230,7 +230,6 @@ add_comgr_test(compile_source_with_device_libs_to_bc_test c)
 add_comgr_test(compile_source_with_device_libs_to_bc_with_vfs_test c)
 add_comgr_test(assemble_test c)
 add_comgr_test(link_test c)
-add_comgr_test(isa_name_parsing_test c)
 add_comgr_test(get_data_isa_name_test c)
 add_comgr_test(include_subdirectory_test c)
 add_comgr_test(demangle_test c)