Skip to content

Commit b6dec82

Browse files
[release/2.10] Fix numpy compatibility for Python 3.14 for 2.10 (#3100)
## Summary - `numpy==2.1.2` has no cp314 wheels on PyPI, causing Python 3.14 builds in TheRock CI to fail with a meson/sccache error when pip falls back to building numpy from source - Add `python_version` markers to use `numpy==2.4.3` for Python 3.14+, while keeping the existing `numpy==2.1.2` pin for older Python versions ## Motivation - Failing: https://github.com/ROCm/TheRock/actions/runs/23488558012/job/68350335718 ## Test Result - https://github.com/ROCm/TheRock/actions/runs/23511528510 - https://github.com/ROCm/TheRock/actions/runs/23516828149 ( latest ) ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
1 parent c19ca7a commit b6dec82

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

requirements-build.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
setuptools==79.0.1
33
cmake==4.0.0
44
ninja==1.11.1.4
5-
numpy==2.1.2
5+
numpy==2.1.2 ; python_version < "3.14"
6+
numpy==2.4.3 ; python_version >= "3.14"
67
packaging==25.0
78
pyyaml==6.0.3
89
requests==2.32.5

requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ lintrunner==0.12.7 ; platform_machine != "s390x" and platform_machine != "riscv6
1414
networkx==2.8.8
1515
ninja==1.11.1.4
1616
numpy==2.0.2 ; python_version == "3.9"
17-
numpy==2.1.2 ; python_version > "3.9"
17+
numpy==2.1.2 ; python_version > "3.9" and python_version < "3.14"
18+
numpy==2.4.3 ; python_version >= "3.14"
1819
optree==0.13.0 ; python_version < "3.14"
1920
optree==0.17.0 ; python_version >= "3.14"
2021
psutil==7.2.2

0 commit comments

Comments
 (0)