Add --hip-link to target_id check (#275)

* Add --hip-link to target_id check

The new driver in clang does not automatically link against the HIP libraries, so we need to add a --hip-link option here to enforce linking. Otherwise we'll get an error on the link stem of check_cxx_compiler_flag() when calling with "-xhip" and "--offload-arch"

Note: The link step isn't really needed for this use case, as invalid targets will fail the compilation step. But check_cxx_compiler_flag() performs both compiling and linking by default

* Update test.yml

Author: lamb-j

.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
         with:
           access_token: ${{ github.token }}
   lint:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
     - uses: actions/checkout@v1
     - name: Set up Python 3.10
@@ -32,8 +32,8 @@ jobs:
       max-parallel: 4
       matrix:
         platform:
-          - ubuntu-20.04
-          - windows-2019
+          - ubuntu-24.04
+          - windows-2022
         cmake-version:
           - 3.31.0
           - 3.22.1

share/rocmcmakebuildtools/cmake/ROCMCheckTargetIds.cmake

@@ -21,6 +21,7 @@ function(rocm_check_target_ids VARIABLE)
     foreach(_target_id ${PARSE_TARGETS})
         _rocm_sanitize_target_id("${_target_id}" _result_var)
         set(_result_var "COMPILER_HAS_TARGET_ID_${_result_var}")
+        set(CMAKE_REQUIRED_LINK_OPTIONS "--hip-link")
         check_cxx_compiler_flag("-xhip --offload-arch=${_target_id}" "${_result_var}")
         if(${_result_var})
             list(APPEND _supported_target_ids "${_target_id}")