When viewing a layer, Edit Layer button does not show up if user has permission to edit data _only_

[BirdSamuel]

If a layer is uploaded with permissions set to give data editing rights to a user, the edit layer button (when viewing that layer) isn't there. This only happens if it is only 'edit data' rights - no other permissions.

The user is still able to modify data on MapLoom, that button just doesn't show up.

 

Here is a handful of permission tests for reference:
There are 3 users:

• admin (default with all rights)
• SBird (normal user - no admin rights)
• NormalUser (second normal user - no admin rights)

Uploading BusStops4326 as admin: - Correct

Expected Result:

• SBird can view it but NOT edit it
• NormalUser cannot view it

Result:

• SBird can view it but NOT edit it
• NormalUser cannot view it

 

Uploading BusStops4326_2 as admin: - Correct

Expected Result:

• SBird cannot view it - CAN edit + download it
• NormalUser can view it

Result:

• SBird cannot view it - Can’t edit + download (can’t see it)
• NormalUser can view it

 

Uploading SoloAmericas1 as NormalUser: - Correct

Expected Result:

• admin cannot view it
• SBird cannot view it

Result:

• admin can view it (expected)
• SBird cannot view it

 

Uploading SoloAmericas1_2 as SBird: - Correct

Expected Result:

• admin cannot view it
• NormalUser can view it - can’t edit

Result:

• admin can view it (expected)
• NormalUser can view it - can’t edit

 

Uploading SoloAmericas1_20 as SBird: - Incorrect

--This is the bug in reference--

Expected Result:

• NormalUser can view it - can edit (data only)

Result:

• NormalUser can view it - can edit (data only) Doesn’t show edit layer on GeoSHAPE

 

Uploading SoloAmericas1_21 as SBird: - Correct

Expected Result:

• NormalUser can view it - can edit (data, styles, and manage)

Result:

• NormalUser can view it - can edit (data, styles, and manage)

 

Uploading SoloAmericas1_22 as SBird: - Correct

Expected Result:

• NormalUser can view it - can edit (data, styles)

Result:

• NormalUser can view it - can edit (data, styles)

 

Uploading SoloAmericas1_23 as SBird: - Correct

Expected Result:

• NormalUser can view it - can edit (styles, manage)

Result:

• NormalUser can view it - can edit (styles, manage)

 

Uploading SoloAmericas1_24 as NormalUser: - Correct

Expected Result:

• SBird can view it - can edit (styles)

Result:

• SBird can view it - can edit (styles)

 

Uploading SoloAmericas1_25 as NormalUser: - Correct

Expected Result:

• SBird can view it - can edit (manage)

Result:

• SBird can view it - can edit (manage)

[pjdufour]

So is this an issue with the html template boolean logic statements then?

https://github.com/GeoNode/geonode/blob/master/geonode/layers/templates/layers/layer_detail.html#L179

In the template, the "Edit Layer" button currently shows if:

if "change_resourcebase_metadata" in perms_list or "change_resourcebase" in perms_list or "delete_resourcebase" in perms_list or "change_layer_style" in layer_perms

Are the add layer permissions not included in "change_resourcebase"?