refactor: creating constants for methods

Author: ROSSARKO

app/src/main/java/hexlet/code/games/Calc.java

@@ -4,13 +4,15 @@
 import hexlet.code.Utils;
 
 public class Calc {
+    private static final int MIN = 0;
+    private static final int MAX = 100;
     public static void startGame() {
         String[][] roundsData = new String[Engine.ROUNDS][2];
         String description = "What is the result of the expression?";
 
         for (int i = 0; i < Engine.ROUNDS; i++) {
-            int num1 = Utils.generateNumber(0, 100);
-            int num2 = Utils.generateNumber(0, 100);
+            int num1 = Utils.generateNumber(MIN, MAX);
+            int num2 = Utils.generateNumber(MIN, MAX);
             char mathSymbol = getRandomMathSymbol();
 
             String question = num1 + " " + mathSymbol + " " + num2;

app/src/main/java/hexlet/code/games/Even.java

@@ -4,12 +4,15 @@
 import hexlet.code.Utils;
 
 public class Even {
+    private static final int MIN = 0;
+    private static final int MAX = 100;
     public static void startGame() {
+
         String description = "Answer 'yes' if the number is even, otherwise answer 'no'.";
         String[][] roundsData = new String[Engine.ROUNDS][2];
 
         for (int i = 0; i < Engine.ROUNDS; i++) {
-            int question = Utils.generateNumber(1, 100);
+            int question = Utils.generateNumber(MIN, MAX);
             String answer = (question % 2 == 0) ? "yes" : "no";
             roundsData[i][0] = String.valueOf(question);
             roundsData[i][1] = answer;

app/src/main/java/hexlet/code/games/GCD.java

@@ -4,13 +4,16 @@
 import hexlet.code.Utils;
 
 public class GCD {
+    private static final int MIN = 0;
+    private static final int MAX = 100;
     public static void startGame() {
+
         String[][] roundsData = new String[Engine.ROUNDS][2];
         String description = "Find the greatest common divisor of given numbers.";
 
         for (int i = 0; i < Engine.ROUNDS; i++) {
-            int num1 = Utils.generateNumber(0, 100);
-            int num2 = Utils.generateNumber(0, 100);
+            int num1 = Utils.generateNumber(MIN, MAX);
+            int num2 = Utils.generateNumber(MIN, MAX);
             String question = num1 + " " + num2;
             int result = gcdCalculate(num1, num2);
             roundsData[i][0] = question;

app/src/main/java/hexlet/code/games/Prime.java

@@ -4,13 +4,15 @@
 import hexlet.code.Utils;
 
 public class Prime {
+    private static final int MIN = 2;
+    private static final int MAX = 1000;
     public static void startGame() {
 
         String[][] roundsData = new String[Engine.ROUNDS][2];
         String description = "Answer 'yes' if given number is prime. Otherwise answer 'no'.";
 
         for (int i = 0; i < Engine.ROUNDS; i++) {
-            int num = Utils.generateNumber(2,1000);
+            int num = Utils.generateNumber(MIN, MAX);
             String answer = isPrime(num) ? "yes" : "no";
             roundsData[i][0] = String.valueOf(num);
             roundsData[i][1] = answer;

app/src/main/java/hexlet/code/games/Progression.java

@@ -4,16 +4,24 @@
 import hexlet.code.Utils;
 
 public class Progression {
+    private static final int PROGRESSION_LENGTH = 10;
+    private static final int STEP_MIN = 1;
+    private static final int STEP_MAX = 10;
+    private static final int FIRST_NUM_MIN = 1;
+    private static final int FIRST_NUM_MAX = 100;
+    private static final int HIDDEN_MIN = 1;
+    private static final int HIDDEN_MAX = 10;
     public static void startGame() {
-        final int PROGRESSION_LENGTH = 10;
+
+
         String[][] roundsData = new String[Engine.ROUNDS][2];
         String description = "What number is missing in the progression?";
 
         for (int i = 0; i < Engine.ROUNDS; i++) {
             String[] progression = makeProgression(
-                Utils.generateNumber(1, 100),
-                Utils.generateNumber(1, 10), PROGRESSION_LENGTH);
-            int hiddenMemberIndex = Utils.generateNumber(0, 9);
+                Utils.generateNumber(FIRST_NUM_MIN, FIRST_NUM_MAX),
+                Utils.generateNumber(STEP_MIN, STEP_MAX), PROGRESSION_LENGTH);
+            int hiddenMemberIndex = Utils.generateNumber(HIDDEN_MIN, HIDDEN_MAX);
             String answer = progression[hiddenMemberIndex];
 
             progression[hiddenMemberIndex] = "..";