[Regression] Batman Arkham City - Rendering issue

[Jonathan44062]

Quick summary

Without realizing it, Batman Arkham City graphics are now corrupted, even when the Write Depth Buffers is enabled

Details

Working - 0.0.25-14483
https://drive.google.com/file/d/11ytzgGQv1qyQ6Zg3uijmbDf9RSaa-Pdt/view?usp=sharing

Regression - 0.0.25-14488 #13077
https://drive.google.com/file/d/1Ur50DcyI3AaAIcAxxhd-7ZA8RKb4qNtJ/view?usp=sharing

Build with regression

0.0.25-14488

Attach two log files

Working
BAC Works.log.gz

Broken
BAC Broken.log

Attach capture files for visual issues

https://www.mediafire.com/file/ldokztjp5xq2ll0/BLUS30978_20240219231033_capture.rrc/file

System configuration

Windows 10 22H2
Intel Core i7-8700
15.93 GiB RAM
GPU: NVIDIA GeForce GTX 1070 Ti (551.52)

Other details

I can share my save file to test better the issue I posted, this is the GOTY Version
https://www.mediafire.com/file/92t7rx0abxidk08/BLUS30978-SAVE0.rar/file

[kd-11]

Why is it never the easy PRs? 😞

[Jonathan44062]

Still an issue.

[digant73]

that broken PR is small and the code is still the same in recent builds. So I simply changed only one line of code on the recent build just to make a test.

@Jonathan44062 could you verify if the attached rpcs3.exe fixes the issue?

eventually the changed code is at line 1658 on texture_cache_utils.h:

if (/*!should_flush() ||*/ get_confirmed_range().inside(flush_exclusions))

just commented out a potential wrong evaluated condition not present on working build 0.0.25-14483

rpcs3.zip

[Jonathan44062]

Your build fixes the broken rendering in Arkham City, same applies for Akham Origins, I tested Arkham Asylum and everything looks fine

[digant73]

thanks for checking. Of course, It's up to kd-11 to investigate on that condition and should_flush() function and provide the fix. Hopefully other bug reports are related to this bug.
It helps a lot to check and find a regression. Otherwise it would be impossible to fix some issues