[Regression] Killzone 3: broken water effect (#15683)

[digant73]

Quick summary

Water effects on killzone 3 have been broken by #15683.
On previous RPCS3 releases it was ok (on par with PS3).
Attached pictures of PS3's effect, RPCS3's correct effect and RPCS3's broken effect

NOTE:
#15683 also affects bug report #15928, although previous water effects were not on par with the effects on a real PS3.

Details

No response

Build with regression

rpcs3-v0.0.32-16592-2647a097_win64

Attach two log files

RPCS3.log.gz

PS3's effect

RPCS3's correct effect

RPCS3's broken effect

Attach capture files for visual issues

Below the links for two RSX captures. One is without any patch while the second is with only MLAA patch applied (MLAA disabled on SPU)). In both cases, the issue is present.

https://mega.nz/file/Pu5kFbIY#hP3mbBwAEZ0bzAGW1x5wfh43f7B2zlf-J027MwjCg2A (no patch applied)
https://mega.nz/file/73ZE1ZZR#WNyjnqOsejNugSg_9fq1tvEb7_fPzVHFoSQ5yxKT7WE (MLAA patch applied)

No response

System configuration

No response

Other details

No response

[FlexBy420]

Missing logs and rsx captures

[digant73]

Missing logs and rsx captures

just attached the log file for RPCS3 with the issue. Shall I attach also the log file for the RPCS3 with no issue?
How can I create the rsx captures?

[FlexBy420]

The log is for resistance 3, not killzone 3
Utilities>create rsx capture

[digant73]

The log is for resistance 3, not killzone 3 Utilities>create rsx capture

Yes, I uploaded the wrong log file. Log file for killzone 3 is now attached.
For the capture, when I start the capture the game is frozen for some seconds before it is asked to press and hold on start button to resume, but the file size is already over 50MB so over the limit of 25MB for the upload

[kd-11]

This is actually progress. We now have a control data point.

[digant73]

This is actually progress. We now have a control data point.

Thanks. I can do some testing if needed.
The regression is also impacting #15928, the water effects are even in that case worse, although even on old RPCS3 releases the water effects didn't match the effects on PS3 (on PS3 there are more transparencies and depth). But, as reported by other more experienced users, it seems that water effect is a common issue on many games from Insomniac

[kd-11]

I need a capture for this one. This engine seems to be setting up multiple conflicting flags, I need to figure out which flags should overwrite the others and in which order.

[digant73]

I need a capture for this one. This engine seems to be setting up multiple conflicting flags, I need to figure out which flags should overwrite the others and in which order.

do you mean from Utilities->Create RSX Capture, right?
I have a capture but it is about 85MB and I cannot upload here (25MB as limit). I will upload the file on another server and provide the link tomorrow

[kd-11]

That's fine.

[digant73]

Ok, below the links for two RSX captures. One is without any patch while the second is with only MLAA patch applied (MLAA disabled on SPU)). In both cases, the issue is present.

https://mega.nz/file/Pu5kFbIY#hP3mbBwAEZ0bzAGW1x5wfh43f7B2zlf-J027MwjCg2A (no patch applied)
https://mega.nz/file/73ZE1ZZR#WNyjnqOsejNugSg_9fq1tvEb7_fPzVHFoSQ5yxKT7WE (MLAA patch applied)

If it can help the troubleshooting, a ghost of the rocks is also present on the water (see the picture below).

Also, on the PS3 waves effects are created on the water by each soldier moving on the water while this effect is absent on RPCS3. However, this missing effect is not a regression of #15683, it is missing also on old RPCS3 versions (I thought that it was due to a feature not yet implemented on RPCS3).

Ghost of rocks on the water: