Fix jni aborts when turbomodule creation throws

Summary:
## Summary
This commit fixes a crash (JNI abort) that occurs when a Java TurboModule's creation throws an exception. The fix applies to two methods: getTurboJavaModule and getLegacyJavaModule.

## Problem
When calling Java methods via fbjni with std::string arguments, fbjni creates temporary local_ref<JString> objects for the converted arguments.

https://www.internalfb.com/code/fbsource/[74f313eee086]/fbandroid/libraries/fbjni/cxx/fbjni/detail/Meta-inl.h?lines=78-89


If the Java method throws an exception:

1. The JNI call returns with a pending exception flag set
2. C++ destroys the temporary jstring arguments (at end of full-expression)
3. The destructor calls GetObjectRefType() while there's a pending exception
4. This violates JNI rules and causes ART's CheckJNI to abort the process

## The Fix
Pre-convert string arguments to jstring before the method call, controlling the lifetime of the local_ref<JString> so it extends past the exception check.

Before:

```
static auto getTurboJavaModule =
    javaPart->getClass()
        ->getMethod<jni::alias_ref<JTurboModule>(const std::string&)>(
            "getTurboJavaModule");
auto moduleInstance = getTurboJavaModule(javaPart.get(), name);
```

After:
```
static auto getTurboJavaModule =
    javaPart->getClass()->getMethod<jni::alias_ref<JTurboModule>(jstring)>(
        "getTurboJavaModule");
auto jname = jni::make_jstring(name);
auto moduleInstance = getTurboJavaModule(javaPart.get(), jname.get());
```

The same change was applied to getLegacyJavaModule.

## Long-term solution
This should be a system fix applied to fbjni. That is done in the subsequent diff.

Changelog: [Android][Fixed] - Fix jni aborts when turbomodule constructors throw

Differential Revision: D88910516

Author: RSNara

packages/react-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.cpp

@@ -176,11 +176,24 @@ std::shared_ptr<TurboModule> TurboModuleManager::getTurboModule(
     return turboModule;
   }
 
+  // TODO(T248203434): Remove this workaround once fixed in fbjni
+  // NOTE: We use jstring instead of std::string for the method signature to
+  // work around a bug in fbjni's exception handling. When a Java method throws
+  // an exception, fbjni's JMethod::operator() needs to check for pending
+  // exceptions via FACEBOOK_JNI_THROW_PENDING_EXCEPTION(). However, if we pass
+  // std::string, fbjni creates a temporary local_ref<JString> for the argument.
+  // C++ destroys temporaries at the end of the full-expression, which happens
+  // AFTER the JNI call returns but BEFORE the exception check. The destructor
+  // calls JNI functions (GetObjectRefType) while there's a pending exception,
+  // which violates JNI rules and causes ART's CheckJNI to abort the process.
+  //
+  // By pre-converting to jstring here, we control the lifetime of the
+  // local_ref<JString> so it extends past the exception check.
   static auto getTurboJavaModule =
-      javaPart->getClass()
-          ->getMethod<jni::alias_ref<JTurboModule>(const std::string&)>(
-              "getTurboJavaModule");
-  auto moduleInstance = getTurboJavaModule(javaPart.get(), name);
+      javaPart->getClass()->getMethod<jni::alias_ref<JTurboModule>(jstring)>(
+          "getTurboJavaModule");
+  auto jname = jni::make_jstring(name);
+  auto moduleInstance = getTurboJavaModule(javaPart.get(), jname.get());
   if (moduleInstance) {
     TurboModulePerfLogger::moduleJSRequireEndingStart(moduleName);
     JavaTurboModule::InitParams params = {
@@ -243,11 +256,24 @@ std::shared_ptr<TurboModule> TurboModuleManager::getLegacyModule(
 
   TurboModulePerfLogger::moduleJSRequireBeginningEnd(moduleName);
 
+  // TODO(T248203434): Remove this workaround once fixed in fbjni
+  // NOTE: We use jstring instead of std::string for the method signature to
+  // work around a bug in fbjni's exception handling. When a Java method throws
+  // an exception, fbjni's JMethod::operator() needs to check for pending
+  // exceptions via FACEBOOK_JNI_THROW_PENDING_EXCEPTION(). However, if we pass
+  // std::string, fbjni creates a temporary local_ref<JString> for the argument.
+  // C++ destroys temporaries at the end of the full-expression, which happens
+  // AFTER the JNI call returns but BEFORE the exception check. The destructor
+  // calls JNI functions (GetObjectRefType) while there's a pending exception,
+  // which violates JNI rules and causes ART's CheckJNI to abort the process.
+  //
+  // By pre-converting to jstring here, we control the lifetime of the
+  // local_ref<JString> so it extends past the exception check.
   static auto getLegacyJavaModule =
-      javaPart->getClass()
-          ->getMethod<jni::alias_ref<JNativeModule>(const std::string&)>(
-              "getLegacyJavaModule");
-  auto moduleInstance = getLegacyJavaModule(javaPart.get(), name);
+      javaPart->getClass()->getMethod<jni::alias_ref<JNativeModule>(jstring)>(
+          "getLegacyJavaModule");
+  auto jname = jni::make_jstring(name);
+  auto moduleInstance = getLegacyJavaModule(javaPart.get(), jname.get());
 
   if (moduleInstance) {
     TurboModulePerfLogger::moduleJSRequireEndingStart(moduleName);