Refactor: Read interop flag directly from feature flags

Summary:
Read from react native feaure flags from within TurboModuleManager.

This makes it easier to call installJSIBindings. The caller doesn't have to read from feature flags beforehand.

Changelog: [Internal]

Differential Revision: D89709217

Author: RSNara

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.kt

@@ -105,8 +105,6 @@ public abstract class ReactPackageTurboModuleManagerDelegate : TurboModuleManage
     }
   }
 
-  override fun unstable_shouldEnableLegacyModuleInterop(): Boolean = shouldEnableLegacyModuleInterop
-
   override fun getModule(moduleName: String): TurboModule? {
     var resolvedModule: NativeModule? = null
 
@@ -153,7 +151,7 @@ public abstract class ReactPackageTurboModuleManagerDelegate : TurboModuleManage
   }
 
   override fun getLegacyModule(moduleName: String): NativeModule? {
-    if (!unstable_shouldEnableLegacyModuleInterop()) {
+    if (!shouldEnableLegacyModuleInterop) {
       return null
     }
 
@@ -191,7 +189,7 @@ public abstract class ReactPackageTurboModuleManagerDelegate : TurboModuleManage
     }
   }
 
-  private fun shouldSupportLegacyPackages(): Boolean = unstable_shouldEnableLegacyModuleInterop()
+  private fun shouldSupportLegacyPackages(): Boolean = shouldEnableLegacyModuleInterop
 
   public abstract class Builder {
     private var packages: List<ReactPackage>? = null

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.kt

@@ -60,7 +60,7 @@ public class TurboModuleManager(
 
   init {
 
-    installJSIBindings(shouldEnableLegacyModuleInterop())
+    installJSIBindings()
 
     eagerInitModuleNames = delegate?.getEagerInitModuleNames() ?: emptyList()
 
@@ -72,7 +72,7 @@ public class TurboModuleManager(
             ModuleProvider { moduleName: String -> delegate.getModule(moduleName) as NativeModule? }
 
     legacyModuleProvider =
-        if (delegate == null || !shouldEnableLegacyModuleInterop()) nullProvider
+        if (delegate == null) nullProvider
         else
             ModuleProvider { moduleName: String ->
               val nativeModule = delegate.getLegacyModule(moduleName)
@@ -93,9 +93,6 @@ public class TurboModuleManager(
   private fun isLegacyModule(moduleName: String): Boolean =
       delegate?.unstable_isLegacyModuleRegistered(moduleName) == true
 
-  private fun shouldEnableLegacyModuleInterop(): Boolean =
-      delegate?.unstable_shouldEnableLegacyModuleInterop() == true
-
   // used from TurboModuleManager.cpp
   @Suppress("unused")
   @DoNotStrip
@@ -287,7 +284,7 @@ public class TurboModuleManager(
       tmmDelegate: TurboModuleManagerDelegate?,
   ): HybridData
 
-  private external fun installJSIBindings(shouldCreateLegacyModules: Boolean)
+  private external fun installJSIBindings()
 
   override fun invalidate() {
     /*

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManagerDelegate.kt

@@ -48,9 +48,6 @@ public abstract class TurboModuleManagerDelegate {
 
   public open fun getEagerInitModuleNames(): List<String> = emptyList()
 
-  /** Can the TurboModule system create legacy modules? */
-  public open fun unstable_shouldEnableLegacyModuleInterop(): Boolean = false
-
   // TODO(T171231381): Consider removing this method: could we just use the static initializer
   // of derived classes instead?
   @Synchronized protected fun maybeLoadOtherSoLibraries(): Unit = Unit

packages/react-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.cpp

@@ -19,6 +19,7 @@
 #include <ReactCommon/JavaInteropTurboModule.h>
 #include <ReactCommon/TurboModuleBinding.h>
 #include <ReactCommon/TurboModulePerfLogger.h>
+#include <react/featureflags/ReactNativeFeatureFlags.h>
 #include <react/jni/CxxModuleWrapperBase.h>
 
 namespace facebook::react {
@@ -227,6 +228,14 @@ std::shared_ptr<TurboModule> TurboModuleManager::getTurboModule(
 TurboModuleProviderFunctionTypeWithRuntime
 TurboModuleManager::createLegacyModuleProvider(
     jni::alias_ref<jhybridobject> javaPart) {
+  bool shouldCreateLegacyModules =
+      ReactNativeFeatureFlags::enableBridgelessArchitecture() &&
+      ReactNativeFeatureFlags::useTurboModuleInterop();
+
+  if (!shouldCreateLegacyModules) {
+    return nullptr;
+  }
+
   return [weakJavaPart = jni::make_weak(javaPart)](
              jsi::Runtime& /*runtime*/,
              const std::string& name) -> std::shared_ptr<TurboModule> {
@@ -314,21 +323,19 @@ std::shared_ptr<TurboModule> TurboModuleManager::getLegacyModule(
 }
 
 void TurboModuleManager::installJSIBindings(
-    jni::alias_ref<jhybridobject> javaPart,
-    bool shouldCreateLegacyModules) {
+    jni::alias_ref<jhybridobject> javaPart) {
   auto cxxPart = javaPart->cthis();
   if (cxxPart == nullptr || !cxxPart->jsCallInvoker_) {
     return; // Runtime doesn't exist when attached to Chrome debugger.
   }
 
-  cxxPart->runtimeExecutor_([javaPart = jni::make_global(javaPart),
-                             shouldCreateLegacyModules](jsi::Runtime& runtime) {
-    TurboModuleBinding::install(
-        runtime,
-        createTurboModuleProvider(javaPart),
-        shouldCreateLegacyModules ? createLegacyModuleProvider(javaPart)
-                                  : nullptr);
-  });
+  cxxPart->runtimeExecutor_(
+      [javaPart = jni::make_global(javaPart)](jsi::Runtime& runtime) {
+        TurboModuleBinding::install(
+            runtime,
+            createTurboModuleProvider(javaPart),
+            createLegacyModuleProvider(javaPart));
+      });
 }
 
 } // namespace facebook::react

packages/react-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.h

@@ -57,7 +57,7 @@ class TurboModuleManager : public jni::HybridClass<TurboModuleManager> {
       std::shared_ptr<NativeMethodCallInvoker> nativeMethodCallInvoker,
       jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate);
 
-  static void installJSIBindings(jni::alias_ref<jhybridobject> javaPart, bool shouldCreateLegacyModules);
+  static void installJSIBindings(jni::alias_ref<jhybridobject> javaPart);
 
   static TurboModuleProviderFunctionTypeWithRuntime createTurboModuleProvider(jni::alias_ref<jhybridobject> javaPart);
   std::shared_ptr<TurboModule>