Latest git not returning RSS feed for GithubPullRequestBridge

[TehPeGaSuS]

Describe the bug
Latest git (2025-01-26 (git.master.00a24e2)) doesn't return RSS feed for GithubPullRequestBridge.

To Reproduce
Steps to reproduce the behavior:

1. Install latest git (00a24e2 at the time of this bug report)
2. Go to the GitHub Pull Request bridge
3. Request RSS Feeds for any project, not checking the Show Pull Request Comments option
4. See error

Expected behavior
The RSS feed for the selected project should be returned.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Ubuntu 24.04.2 LTS
• Browser: Google Chrome
• Version: Version 133.0.6943.141 (Official Build) (64-bit)

Smartphone (please complete the following information):

• Device: N/A
• OS: N/A
• Browser: N/A
• Version: N/A

Additional context
The latest release RSS-Bridge 2025-01-26 does seem to work properly

Test instance: https://rssfeeds.duckdns.org/ (may be a bit slow, due to DuckDNS issues, probably)

URL for WeeChat PRs: https://rssfeeds.duckdns.org/?action=display&bridge=GithubPullRequestBridge&context=Project+Pull+Requests&q=is%3Apr&u=weechat&p=weechat&format=Html

[TehPeGaSuS]

If I do curl "https://github.com/RSS-Bridge/rss-bridge/pulls?q=is%3Apr+is%3Aopen+sort%3Acreated-desc" I can see the HTML output on the terminal console.

[KappaPrajd]

It looks like GitHub changed most CSS classes for Pull Requests, they now differ a lot from Issues.

Patching things up may look ugly with current implementation where GitHubPullRequestBridge is inheriting from GithubIssueBridge.

It may be worth considering splitting those two, and moving common functionalities (if any) to some abstract helper class.

@dvikan

[TehPeGaSuS]

I got this on a recent instance:

Details
Type: Error
Code: 0
Message: Call to undefined function mb_strlen()
File: lib/html.php
Line: 83
Trace
#0 index.php(73): RssBridge->main()
#1 lib/RssBridge.php(39): RssBridge->{closure}()
#2 lib/RssBridge.php(37): CacheMiddleware->__invoke()
#3 middlewares/CacheMiddleware.php(44): RssBridge->{closure}()
#4 lib/RssBridge.php(37): ExceptionMiddleware->__invoke()
#5 middlewares/ExceptionMiddleware.php(17): RssBridge->{closure}()
#6 lib/RssBridge.php(37): SecurityMiddleware->__invoke()
#7 middlewares/SecurityMiddleware.php(19): RssBridge->{closure}()
#8 lib/RssBridge.php(37): MaintenanceMiddleware->__invoke()
#9 middlewares/MaintenanceMiddleware.php(10): RssBridge->{closure}()
#10 lib/RssBridge.php(37): BasicAuthMiddleware->__invoke()
#11 middlewares/BasicAuthMiddleware.php(13): RssBridge->{closure}()
#12 lib/RssBridge.php(37): TokenAuthenticationMiddleware->__invoke()
#13 middlewares/TokenAuthenticationMiddleware.php(10): RssBridge->{closure}()
#14 lib/RssBridge.php(34): DisplayAction->__invoke()
#15 actions/DisplayAction.php(54): DisplayAction->createResponse()
#16 actions/DisplayAction.php(130): FormatAbstract->setItems()
#17 lib/FormatAbstract.php(35): FeedItem::fromArray()
#18 lib/FeedItem.php(21): FeedItem->__set()
#19 lib/FeedItem.php(41): FeedItem->setTitle()
#20 lib/FeedItem.php(135): truncate()
#21 lib/html.php(83)

Context
Query: action=display&bridge=GithubPullRequestBridge&context=Project Pull Requests&q=is:pr&u=weechat&p=weechat&format=Html
Version: 2025-01-26 (git.master.95af1ff)
OS: Linux
PHP: 8.3.6

[dvikan]

@TehPeGaSuS apt install php-mbstring

[TehPeGaSuS]

@TehPeGaSuS apt install php-mbstring

Yeah, that fixed the issue of the problem above.

I guess we still need the bridge itself to be fixed when it comes to the original issue?