Skip to content

Commit 291ba96

Browse files
Corrected a bad statement running Tcl_NewListObj() that fails to
assign the result to anything, causing later uses of variable "lobj" to have an unitialized value and potentially causing a crash condition. Thanks to Risto Bell for pointing out the error.
1 parent e4c28ef commit 291ba96

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8.3.482
1+
8.3.483

commands/CmdRS.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -2338,8 +2338,7 @@ CmdSetLabel(w, cmd)
23382338
if (locargc == 2)
23392339
{
23402340
#ifdef MAGIC_WRAPPER
2341-
Tcl_Obj *lobj;
2342-
Tcl_NewListObj(0, NULL);
2341+
lobj = Tcl_NewListObj(0, NULL);
23432342
Tcl_ListObjAppendElement(magicinterp, lobj,
23442343
Tcl_NewIntObj(DefaultLabel->lab_offset.p_x));
23452344
Tcl_ListObjAppendElement(magicinterp, lobj,

0 commit comments

Comments
 (0)