Skip to content

Commit a5fa0a3

Browse files
committed
Fix some issue in docstrings and documentation
1 parent 056b292 commit a5fa0a3

4 files changed

Lines changed: 42 additions & 32 deletions

File tree

carbonfly/case.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def build_case(
155155
"""
156156
Build an OpenFOAM case folder structure and write key dictionaries/fields.
157157
158-
High-level steps:
158+
Steps:
159159
1) Mesh each CFGeo.brep and export a multi-solid ASCII STL.
160160
2) Optionally write `system/blockMeshDict`.
161161
3) Optionally write `system/surfaceFeaturesDict` and `system/snappyHexMeshDict`.
@@ -180,7 +180,8 @@ def build_case(
180180
internal_G: Optional internalField for G.
181181
internal_Ydefault: Optional internalField for Ydefault.
182182
write_blockmesh (bool): If True, write `system/blockMeshDict`.
183-
padding_m (float): Extra margin (in meters) added around the union of all CFGeo bounding boxes when computing the blockMesh domain extents.
183+
padding_m (float): Extra margin (in meters) added around the union of all CFGeo bounding boxes
184+
when computing the blockMesh domain extents.
184185
cell_size_m (float): Target cell size (m) used to derive blockMesh cell counts.
185186
write_snappy (bool): If True, write snappyHexMesh-related dictionaries.
186187
snap (bool): `snap` switch in snappyHexMeshDict.

carbonfly/iaq.py

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -65,50 +65,50 @@ def iaq_co2(
6565
6666
Notes:
6767
- EN: European standard CEN/EN 16798-1, based on german version DIN EN 16798-1:2019 (Page 55).
68-
Evaluation based on CO2 concentration differences between indoors and outdoors.
69-
- [Index = 1] Category I: delta(CO2) <= 550 ppm
70-
- [Index = 2] Category II: delta(CO2) <= 800 ppm
71-
- [Index = 3] Category III: delta(CO2) <= 1350 ppm
72-
- [Index = 4] Category IV: delta(CO2) > 1350 ppm
68+
Evaluation based on CO2 concentration differences between indoors and outdoors.
69+
- [Index = 1] Category I: delta(CO2) <= 550 ppm
70+
- [Index = 2] Category II: delta(CO2) <= 800 ppm
71+
- [Index = 3] Category III: delta(CO2) <= 1350 ppm
72+
- [Index = 4] Category IV: delta(CO2) > 1350 ppm
7373
7474
- LEHB: Japanese law for environmental health in buildings (LEHB).
75-
Evaluation based on CO2 concentration indoors.
76-
- [Index = 1] Acceptable: CO2 <= 1000 ppm
77-
- [Index = 2] Unacceptable: CO2 > 1000 ppm
75+
Evaluation based on CO2 concentration indoors.
76+
- [Index = 1] Acceptable: CO2 <= 1000 ppm
77+
- [Index = 2] Unacceptable: CO2 > 1000 ppm
7878
7979
- SS: Singapore standard SS 554:2016 (Page 22).
80-
Evaluation based on CO2 concentration differences between indoors and outdoors.
81-
- [Index = 1] Acceptable: delta(CO2) <= 700 ppm
82-
- [Index = 2] Unacceptable: delta(CO2) > 700 ppm
80+
Evaluation based on CO2 concentration differences between indoors and outdoors.
81+
- [Index = 1] Acceptable: delta(CO2) <= 700 ppm
82+
- [Index = 2] Unacceptable: delta(CO2) > 700 ppm
8383
8484
- HK: Hong Kong Environmental Protection Department.
85-
"Hongkong Guidance Notes for the Management of Indoor Air Quality in Offices and Public Places" (Page 17).
86-
Evaluation based on CO2 concentration indoors (averaging time 8-hour). Here the average is changed
87-
to an instantaneous evaluation for each measurment.
88-
- [Index = 1] Excellent Class: CO2 <= 800 ppm
89-
- [Index = 2] Good Class: CO2 <= 1000 ppm
90-
- [Index = 3] Unacceptable: CO2 > 1000 ppm
85+
"Hongkong Guidance Notes for the Management of Indoor Air Quality in Offices and Public Places" (Page 17).
86+
Evaluation based on CO2 concentration indoors (averaging time 8-hour). Here the average is changed
87+
to an instantaneous evaluation for each measurment.
88+
- [Index = 1] Excellent Class: CO2 <= 800 ppm
89+
- [Index = 2] Good Class: CO2 <= 1000 ppm
90+
- [Index = 3] Unacceptable: CO2 > 1000 ppm
9191
9292
- UBA: German environmental protection agency (Umweltbundesamt).
93-
"Gesundheitsschutz 11-2008: Gesundheitliche Bewertung von Kohlendioxid in der Innenraumluft" (Page 1368).
94-
Evaluation based on CO2 concentration indoors.
95-
- [Index = 1] Hygienically safe: CO2 < 1000 ppm
96-
- [Index = 2] Hygienically conspicuous: CO2 <= 2000 ppm
97-
- [Index = 3] Hygienically unacceptable: CO2 > 2000 ppm
93+
"Gesundheitsschutz 11-2008: Gesundheitliche Bewertung von Kohlendioxid in der Innenraumluft" (Page 1368).
94+
Evaluation based on CO2 concentration indoors.
95+
- [Index = 1] Hygienically safe: CO2 < 1000 ppm
96+
- [Index = 2] Hygienically conspicuous: CO2 <= 2000 ppm
97+
- [Index = 3] Hygienically unacceptable: CO2 > 2000 ppm
9898
9999
- DOSH: Department of Occupational Safety and Health (DOSH) Malaysia.
100-
"Industry Code of Practice on Indoor Air Quality 2010 (ICOP IAQ 2010)."
101-
Evaluation based on CO2 concentration indoors.
102-
- [Index = 1] Acceptable: CO2 <= 1000 ppm
103-
- [Index = 2] Unacceptable: CO2 > 1000 ppm
100+
"Industry Code of Practice on Indoor Air Quality 2010 (ICOP IAQ 2010)."
101+
Evaluation based on CO2 concentration indoors.
102+
- [Index = 1] Acceptable: CO2 <= 1000 ppm
103+
- [Index = 2] Unacceptable: CO2 > 1000 ppm
104104
105105
- NBR: Brazilian standard ABNT NBR 16401-3:2008
106106
"Air-conditioning installations – Central and unitary systems – Part 3: Indoor air quality"
107107
and ABNT NBR 17037:2023
108108
"Indoor air quality in artificially heated non-residential environments – Referential standards"
109-
Evaluation based on CO2 concentration differences between indoors and outdoors.
110-
- [Index = 1] Acceptable: delta(CO2) <= 700 ppm
111-
- [Index = 2] Unacceptable: delta(CO2) > 700 ppm
109+
Evaluation based on CO2 concentration differences between indoors and outdoors.
110+
- [Index = 1] Acceptable: delta(CO2) <= 700 ppm
111+
- [Index = 2] Unacceptable: delta(CO2) > 700 ppm
112112
"""
113113
standards = ["EN", "LEHB", "SS", "HK", "UBA", "DOSH", "NBR"]
114114
if standard not in standards:

carbonfly/utils.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,20 @@ def wind_pressure_en1991(
234234
zone: External pressure zones, A/B/C on side/roof edges along the flow, D windward face, and E leeward face.
235235
Schematic (Fig. 7.5) see Notes.
236236
terrain: terrain type, 0/1/2/3/4, default: 4, corresponding to Type 0/I/II/III/IV:
237+
237238
0: Sea, coastal area exposed to the open sea.
239+
238240
1: Lakes or area with negligible vegetation and without obstacles.
241+
239242
2: Area with low vegetation such as grass and isolated obstacles (trees, buildings) with separations of
240243
at least 20 obstacle heights.
244+
241245
3: Area with regular cover of vegetation or buildings or with isolated obstacles with separations of
242246
maximum 20 obstacle heights (such as villages, suburban terrain, permanent forest).
247+
243248
4: Area in which at least 15 % of the surface is covered with buildings and their average height
244249
exceeds 15 m.
250+
245251
c_dir: directional factor, for various wind directions may be found in the National Annex.
246252
The recommended value is 1.0.
247253
c_season: season factor, may be given in the National Annex. The recommended value is 1.0.

docs/source/api.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
API Documentation
22
=================
33

4+
This section contains the complete API reference of the **Carbonfly** Python package.
5+
It covers geometry handling in Rhino/Grasshopper, OpenFOAM case generation,
6+
WSL-based execution, and post-processing utilities.
7+
48
.. toctree::
59
:maxdepth: 4
6-
:hidden:
710

811
carbonfly

0 commit comments

Comments
 (0)