Skip to content

Commit ca8561d

Browse files
committed
Avoid multiple migrations having the same version number
1 parent 459f443 commit ca8561d

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Diff for: rails_event_store/spec/rails_foreign_key_on_event_id_migration_generator_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def generate_migration
7878
end
7979

8080
def second_step_migration_exists?(dir)
81-
File.exist?("#{dir}/db/migrate/20160809222222_validate_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb")
81+
File.exist?("#{dir}/db/migrate/20160809222223_validate_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb")
8282
end
8383

8484
def generated_files_count(dir)

Diff for: ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/rails_foreign_key_on_event_id_migration_generator.rb

+6-5
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@ def initialize(*args)
2727
def create_migration
2828
case @database_adapter
2929
when DatabaseAdapter::PostgreSQL
30+
time = Time.now
3031
template "#{@database_adapter.template_directory}add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
31-
"db/migrate/#{timestamp}_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
32+
"db/migrate/#{migration_verion_number(time)}_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
3233
template "#{@database_adapter.template_directory}validate_add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
33-
"db/migrate/#{timestamp}_validate_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
34+
"db/migrate/#{migration_verion_number(time + 1)}_validate_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
3435
else
3536
template "#{@database_adapter.template_directory}add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
36-
"db/migrate/#{timestamp}_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
37+
"db/migrate/#{migration_verion_number(Time.now)}_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
3738
end
3839
end
3940

@@ -47,8 +48,8 @@ def migration_version
4748
::ActiveRecord::Migration.current_version
4849
end
4950

50-
def timestamp
51-
Time.now.strftime("%Y%m%d%H%M%S")
51+
def migration_verion_number(time)
52+
time.strftime("%Y%m%d%H%M%S")
5253
end
5354
end
5455
end

0 commit comments

Comments
 (0)