Commit 4a966b2
Fix: SIGSEGV in AggregationFuzzer when reference query returns empty result vector (facebookincubator#17018)
Summary:
Pull Request resolved: facebookincubator#17018
`compareEquivalentPlanResults` calls `mergeRowVectors` on the reference query result without checking if the result vector is empty. When the reference query runner (e.g. SparkQueryRunner) returns a valid `optional` containing an empty `vector<RowVectorPtr>` (query succeeded but produced zero result batches), `mergeRowVectors` crashes accessing `results[0]` on an empty vector.
This was the root cause of recurring Spark Aggregate Fuzzer SIGSEGV crashes in the scheduled CI (e.g. seed 13256, iteration 6).
The fix adds an emptiness check on the result vector before calling
`mergeRowVectors`.
Reviewed By: kgpai
Differential Revision: D99347601
fbshipit-source-id: 9deff0630f7f8e124ffa0a98c9a8b89102fc8acb1 parent 4bbea83 commit 4a966b2
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1079 | 1079 | | |
1080 | 1080 | | |
1081 | 1081 | | |
1082 | | - | |
| 1082 | + | |
1083 | 1083 | | |
1084 | 1084 | | |
1085 | 1085 | | |
| |||
0 commit comments