Seems like we're better off reconnecting ourselves, otherwise it leads to a 'Hermes WebSocket closed with code 4122, from host true, reason invalid challenge'

Author: Rakambda

miner/src/main/java/fr/rakambda/channelpointsminer/miner/api/hermes/TwitchHermesWebSocketClient.java

@@ -39,7 +39,6 @@
 import java.util.UUID;
 import java.util.concurrent.ConcurrentLinkedQueue;
 import static org.java_websocket.framing.CloseFrame.GOING_AWAY;
-import static org.java_websocket.framing.CloseFrame.NORMAL;
 
 @Log4j2
 public class TwitchHermesWebSocketClient extends WebSocketClient{
@@ -96,14 +95,9 @@ public void onMessage(String messageStr){
 					subscribeRequests.remove(unsubscribeResponse.getUnsubscribeResponse().getSubscription().getId());
 				}
 				case NotificationResponse notificationResponse -> log.debug("Received Hermes notification of type {}", notificationResponse.getNotification().getClass().getSimpleName());
-				case ReconnectResponse reconnectResponse -> {
-					if(Objects.nonNull(reconnectResponse.getReconnect()) && Objects.nonNull(reconnectResponse.getReconnect().getUrl())){
-						close(NORMAL);
-					}
-					else{
-						log.warn("Received Hermes reconnect response without a reconnect URL");
-						close(GOING_AWAY);
-					}
+				case ReconnectResponse ignored -> {
+					log.warn("Received Hermes reconnect response");
+					close(GOING_AWAY);
 				}
 				default -> {
 				}

miner/src/main/java/fr/rakambda/channelpointsminer/miner/api/hermes/TwitchHermesWebSocketPool.java

@@ -86,16 +86,6 @@ public void onWebSocketMessage(@NotNull ITwitchHermesWebSocketResponse response)
 		if(response instanceof UnsubscribeResponse u){
 			topics.remove(u.getUnsubscribeResponse().getSubscription().getId());
 		}
-		if(response instanceof ReconnectResponse r){
-			if(Objects.nonNull(r.getReconnect()) && Objects.nonNull(r.getReconnect().getUrl())){
-				try{
-					createReconnectClient(r.getReconnect().getUrl()); // TODO do the subscription ids change ?
-				}
-				catch(Exception e){
-					eventManager.onEvent(new ErrorEvent("Hermes API", "Failed to reconnect client with reconnect URL", e));
-				}
-			}
-		}
 		if(response instanceof NotificationResponse n){
 			if(n.getNotification() instanceof PubSubNotificationType t){
 				if(Objects.isNull(t.getPubsub())){

miner/src/test/java/fr/rakambda/channelpointsminer/miner/api/hermes/TwitchHermesWebSocketReconnectTest.java

@@ -68,7 +68,7 @@ void onResponseWithReconnectUrl(WebsocketMockServer server) throws InterruptedEx
 						.build())
 				.build();
 		verify(listener, timeout(MESSAGE_TIMEOUT)).onWebSocketMessage(expected);
-		verify(listener).onWebSocketClosed(eq(tested), eq(NORMAL), anyString(), anyBoolean());
+		verify(listener).onWebSocketClosed(eq(tested), eq(GOING_AWAY), anyString(), anyBoolean());
 	}
 
 	@BeforeEach