Rely solely on stream up/down events again (#1136)

## Pull Request Etiquette

### Checklist

- [x] Tests have been added in relevant areas
- [x] Corresponding changes made to the documentation (README.adoc) <!--
(if irrelevant check the box too) -->

### Type of change
Internal change
<!-- Choose one from "Bug fix" / "New Feature" / "Breaking change" /
"Internal change" -->

## Description

<!-- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

Author: Rakambda

miner/src/main/java/fr/rakambda/channelpointsminer/miner/handler/StreamStartEndHandler.java

@@ -43,25 +43,25 @@ public void onStreamDown(@NonNull Topic topic, @NonNull StreamDown message){
 		streamDown(streamerId, streamer.orElse(null), streamer.map(Streamer::getUsername).orElse(null), message.getServerTime(), true);
 	}
 
-	@Override
-	public void onBroadcastSettingsUpdate(@NonNull Topic topic, @NonNull BroadcastSettingsUpdate message){
-		var streamerId = message.getChannelId();
-		var streamer = miner.getStreamerById(streamerId);
-		
-		var status = miner.getGqlApi().withIsStreamLive(streamerId);
-		var streaming = status.map(GQLResponse::getData).map(d -> Objects.nonNull(d.getUser().getStream()));
-		var memoryStreaming = streamer.map(Streamer::isStreaming).orElse(false);
-		
-		// Fire event only if we know the current streaming status, and it is different from what we currently have in memory (i.e. the stream status changed and not just some parameters)
-		var fireEvent = streaming.isPresent() && streaming.get() != memoryStreaming;
-		
-		if(streaming.orElseGet(() -> !memoryStreaming)){
-			streamUp(streamerId, streamer.orElse(null), streamer.map(Streamer::getUsername).orElse(null), TimeFactory.now(), fireEvent);
-		}
-		else{
-			streamDown(streamerId, streamer.orElse(null), streamer.map(Streamer::getUsername).orElse(null), TimeFactory.now(), fireEvent);
-		}
-	}
+	// @Override
+	// public void onBroadcastSettingsUpdate(@NonNull Topic topic, @NonNull BroadcastSettingsUpdate message){
+	// 	var streamerId = message.getChannelId();
+	// 	var streamer = miner.getStreamerById(streamerId);
+	//	
+	// 	var status = miner.getGqlApi().withIsStreamLive(streamerId);
+	// 	var streaming = status.map(GQLResponse::getData).map(d -> Objects.nonNull(d.getUser().getStream()));
+	// 	var memoryStreaming = streamer.map(Streamer::isStreaming).orElse(false);
+	//	
+	// 	// Fire event only if we know the current streaming status, and it is different from what we currently have in memory (i.e. the stream status changed and not just some parameters)
+	// 	var fireEvent = streaming.isPresent() && streaming.get() != memoryStreaming;
+	//	
+	// 	if(streaming.orElseGet(() -> !memoryStreaming)){
+	// 		streamUp(streamerId, streamer.orElse(null), streamer.map(Streamer::getUsername).orElse(null), TimeFactory.now(), fireEvent);
+	// 	}
+	// 	else{
+	// 		streamDown(streamerId, streamer.orElse(null), streamer.map(Streamer::getUsername).orElse(null), TimeFactory.now(), fireEvent);
+	// 	}
+	// }
 
 	private void streamUp(@NonNull String streamerId, @Nullable Streamer streamer, @Nullable String username, @NonNull Instant serverTime, boolean fireEvent){
 		updateStream(streamerId, streamer);

miner/src/test/java/fr/rakambda/channelpointsminer/miner/handler/StreamStartEndHandlerTest.java

@@ -18,6 +18,7 @@
 import fr.rakambda.channelpointsminer.miner.streamer.Streamer;
 import fr.rakambda.channelpointsminer.miner.streamer.StreamerSettings;
 import fr.rakambda.channelpointsminer.miner.tests.ParallelizableTest;
+import org.junit.jupiter.api.Disabled;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
@@ -166,6 +167,7 @@ void streamDownUnknown(){
 		verify(chatClient, never()).leave(any());
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndNotStreamingFromGql(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){
@@ -189,6 +191,7 @@ void broadcastSettingsUpdateAndNotStreamingFromGql(){
 		}
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndStreamingFromGql(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){
@@ -210,6 +213,7 @@ void broadcastSettingsUpdateAndStreamingFromGql(){
 		}
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndNotStreamingFromGqlButStateDidNotChange(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){
@@ -232,6 +236,7 @@ void broadcastSettingsUpdateAndNotStreamingFromGqlButStateDidNotChange(){
 		}
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndStreamingFromGqlButStateDidNotChange(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){
@@ -254,6 +259,7 @@ void broadcastSettingsUpdateAndStreamingFromGqlButStateDidNotChange(){
 		}
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndNotStreamingFromMemory(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){
@@ -276,6 +282,7 @@ void broadcastSettingsUpdateAndNotStreamingFromMemory(){
 		}
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndStreamingFromMemory(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){
@@ -299,6 +306,7 @@ void broadcastSettingsUpdateAndStreamingFromMemory(){
 		}
 	}
 
+	@Disabled("Rely on stream up/down")
 	@Test
 	void broadcastSettingsUpdateAndUnknown(){
 		try(var timeFactory = mockStatic(TimeFactory.class)){