Skip to content

Commit 79cc8d5

Browse files
Fix event renaming breaking change in NeoForge 26.1.2.21+ and handle @OnlyIn warning (#1097)
Switched references of BlockEvent.BreakEvent to BreakBlockEvent and updated the neoforge version to 26.1.2.21-beta. --------- Co-authored-by: Thomas <1688389+Rakambda@users.noreply.github.com>
1 parent 4a1c269 commit 79cc8d5

7 files changed

Lines changed: 12 additions & 16 deletions

File tree

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ fabric-loader-version = "0.19.2"
1212
fabric-api-version = "0.145.4+26.1.2"
1313
forge-version = "26.1.2-64.0.5"
1414
forgeEventbusValidator-version = "7.0.5"
15-
neoforgeVersion = "26.1.2.1-beta"
15+
neoforgeVersion = "26.1.2.29-beta"
1616

1717
# Mod dependencies
1818
modmenu-version = "18.0.0-alpha.8"

neoforge/src/main/java/fr/rakambda/fallingtree/neoforge/client/cloth/ClothConfigHook.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
import fr.rakambda.fallingtree.common.wrapper.IComponent;
2121
import me.shedaniel.clothconfig2.api.ConfigBuilder;
2222
import net.minecraft.network.chat.Component;
23-
import net.neoforged.api.distmarker.Dist;
24-
import net.neoforged.api.distmarker.OnlyIn;
2523
import net.neoforged.fml.ModContainer;
2624
import net.neoforged.neoforge.client.gui.IConfigScreenFactory;
2725
import org.jspecify.annotations.NonNull;
@@ -52,7 +50,6 @@ public void load(ModContainer modContainer){
5250
});
5351
}
5452

55-
@OnlyIn(Dist.CLIENT)
5653
public void fillConfigScreen(@NonNull ConfigBuilder builder, @NonNull Configuration config){
5754
var reverseSneakingEntry = builder.entryBuilder()
5855
.startEnumSelector(translatable(getFieldName(null, "sneakMode")), SneakMode.class, config.getSneakMode())
@@ -91,7 +88,6 @@ public void fillConfigScreen(@NonNull ConfigBuilder builder, @NonNull Configurat
9188
fillEnchantmentConfigScreen(builder, config.getEnchantment());
9289
}
9390

94-
@OnlyIn(Dist.CLIENT)
9591
private void fillTreesConfigScreen(@NonNull ConfigBuilder builder, @NonNull TreeConfiguration config){
9692
var breakModeEntry = builder.entryBuilder()
9793
.startEnumSelector(translatable(getFieldName("trees", "breakMode")), BreakMode.class, config.getBreakMode())
@@ -294,7 +290,6 @@ private void fillTreesConfigScreen(@NonNull ConfigBuilder builder, @NonNull Tree
294290
trees.addEntry(trunkLootPercentageEntry);
295291
}
296292

297-
@OnlyIn(Dist.CLIENT)
298293
private void fillToolsConfigScreen(@NonNull ConfigBuilder builder, @NonNull ToolConfiguration config){
299294
var ignoreToolsEntry = builder.entryBuilder()
300295
.startBooleanToggle(translatable(getFieldName("tools", "ignoreTools")), config.isIgnoreTools())
@@ -362,7 +357,6 @@ private void fillToolsConfigScreen(@NonNull ConfigBuilder builder, @NonNull Tool
362357
tools.addEntry(forceToolUsageEntry);
363358
}
364359

365-
@OnlyIn(Dist.CLIENT)
366360
private void fillPlayerConfigScreen(@NonNull ConfigBuilder builder, @NonNull PlayerConfiguration config){
367361
var allowedTagsEntry = builder.entryBuilder()
368362
.startStrList(translatable(getFieldName("player", "allowedTags")), config.getAllowedTags())
@@ -375,7 +369,6 @@ private void fillPlayerConfigScreen(@NonNull ConfigBuilder builder, @NonNull Pla
375369
tools.addEntry(allowedTagsEntry);
376370
}
377371

378-
@OnlyIn(Dist.CLIENT)
379372
private void fillEnchantmentConfigScreen(@NonNull ConfigBuilder builder, @NonNull EnchantmentConfiguration config){
380373
var requireEnchantmentEntry = builder.entryBuilder()
381374
.startBooleanToggle(translatable(getFieldName("enchantment", "requireEnchantment")), config.isRequireEnchantment())

neoforge/src/main/java/fr/rakambda/fallingtree/neoforge/common/FallingTreeCommonsImpl.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
import net.neoforged.bus.api.IEventBus;
4747
import net.neoforged.neoforge.common.NeoForge;
4848
import net.neoforged.neoforge.event.level.BlockEvent;
49+
import net.neoforged.neoforge.event.level.block.BreakBlockEvent;
4950
import org.jspecify.annotations.NonNull;
5051
import java.util.Arrays;
5152
import java.util.HashMap;
@@ -68,7 +69,7 @@ public class FallingTreeCommonsImpl extends FallingTreeCommon<Direction>{
6869
private final TagKey<Enchantment> chopperEnchantmentTag;
6970
@Getter
7071
private final Map<BreakMode, TagKey<Enchantment>> breakModeChopperEnchantmentTag;
71-
private final List<BlockEvent.BreakEvent> breakEvents;
72+
private final List<BreakBlockEvent> breakEvents;
7273

7374
private final Map<IBlock, Boolean> isLogBlockCache;
7475
private final Map<IBlock, Boolean> isLeafBlockCache;
@@ -226,9 +227,9 @@ public boolean checkCanBreakBlock(@NonNull ILevel level, @NonNull IBlockPos bloc
226227

227228
@Override
228229
public boolean isOwnEvent(@NonNull IBlockBreakEvent event){
229-
var result = breakEvents.contains((BlockEvent.BreakEvent) event.getRaw()) || event instanceof FallingTreeBlockBreakEvent;
230+
var result = breakEvents.contains((BreakBlockEvent) event.getRaw()) || event instanceof FallingTreeBlockBreakEvent;
230231
if(result){
231-
breakEvents.remove((BlockEvent.BreakEvent) event.getRaw());
232+
breakEvents.remove((BreakBlockEvent) event.getRaw());
232233
}
233234
return result;
234235
}

neoforge/src/main/java/fr/rakambda/fallingtree/neoforge/common/wrapper/BlockBreakEventWrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
import lombok.Getter;
66
import lombok.RequiredArgsConstructor;
77
import lombok.ToString;
8-
import net.neoforged.neoforge.event.level.BlockEvent;
8+
import net.neoforged.neoforge.event.level.block.BreakBlockEvent;
99
import org.jspecify.annotations.NonNull;
1010

1111
@RequiredArgsConstructor
1212
@ToString
1313
public class BlockBreakEventWrapper implements IBlockBreakEvent{
1414
@Getter
15-
private final BlockEvent.@NonNull BreakEvent raw;
15+
private final @NonNull BreakBlockEvent raw;
1616

1717
@Override
1818
@NonNull

neoforge/src/main/java/fr/rakambda/fallingtree/neoforge/event/BlockBreakListener.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import net.neoforged.bus.api.SubscribeEvent;
1313
import net.neoforged.neoforge.event.entity.player.PlayerEvent;
1414
import net.neoforged.neoforge.event.level.BlockEvent;
15+
import net.neoforged.neoforge.event.level.block.BreakBlockEvent;
1516
import org.jspecify.annotations.NonNull;
1617
import javax.annotation.Nonnull;
1718

@@ -44,7 +45,7 @@ public void onBreakSpeed(@Nonnull PlayerEvent.BreakSpeed event){
4445
}
4546

4647
@SubscribeEvent
47-
public void onBlockBreakEvent(@Nonnull BlockEvent.BreakEvent event){
48+
public void onBlockBreakEvent(@Nonnull BreakBlockEvent event){
4849
if(event.isCanceled()){
4950
return;
5051
}

neoforge/src/main/java/fr/rakambda/fallingtree/neoforge/event/FallingTreeBlockBreakEvent.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
import net.minecraft.world.level.Level;
66
import net.minecraft.world.level.block.state.BlockState;
77
import net.neoforged.neoforge.event.level.BlockEvent;
8+
import net.neoforged.neoforge.event.level.block.BreakBlockEvent;
89

9-
public class FallingTreeBlockBreakEvent extends BlockEvent.BreakEvent{
10+
public class FallingTreeBlockBreakEvent extends BreakBlockEvent{
1011
public FallingTreeBlockBreakEvent(Level level, BlockPos pos, BlockState state, Player player){
1112
super(level, pos, state, player);
1213
}

neoforge/src/main/resources/META-INF/neoforge.mods.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ file="META-INF/neoforge.accesstransformer.cfg"
1515
[[dependencies.fallingtree]]
1616
modId="neoforge"
1717
type="required"
18-
versionRange="[26.1.2,)"
18+
versionRange="[26.1.2.21,)"
1919
ordering="NONE"
2020
side="BOTH"
2121
[[dependencies.fallingtree]]

0 commit comments

Comments
 (0)