kubeobjects: exclude ramen objects from velero backup

When we create a backup request, we add a match expression that excludes
the resources created by ramen. This way we don't have to ask the users
to exclude ramen resources explicitly in their recipes.

Signed-off-by: Raghavendra Talur <[email protected]>
Co-Authored-by: Abhijeet Shakya <[email protected]>

Author: raghavendra-talur

internal/controller/kubeobjects/velero/requests.go

@@ -373,14 +373,28 @@ func backupRealCreate(
 }
 
 func getBackupSpecFromObjectsSpec(objectsSpec kubeobjects.Spec) velero.BackupSpec {
+	if objectsSpec.LabelSelector == nil {
+		objectsSpec.LabelSelector = &metav1.LabelSelector{}
+	}
+
+	newLabelSelector := objectsSpec.LabelSelector
+	newLabelSelector.MatchExpressions = append(
+		newLabelSelector.MatchExpressions,
+		metav1.LabelSelectorRequirement{
+			Key:      util.CreatedByRamenLabel,
+			Operator: metav1.LabelSelectorOpNotIn,
+			Values:   []string{"true"},
+		},
+	)
+
 	return velero.BackupSpec{
 		IncludedNamespaces: objectsSpec.IncludedNamespaces,
 		IncludedResources:  objectsSpec.IncludedResources,
 		// exclude VRs from Backup so VRG can create them: see https://github.com/RamenDR/ramen/issues/884
 		ExcludedResources: append(objectsSpec.ExcludedResources, "volumereplications.replication.storage.openshift.io",
 			"replicationsources.volsync.backube", "replicationdestinations.volsync.backube",
 			"PersistentVolumeClaims", "PersistentVolumes"),
-		LabelSelector:           objectsSpec.LabelSelector,
+		LabelSelector:           newLabelSelector,
 		OrLabelSelectors:        objectsSpec.OrLabelSelectors,
 		TTL:                     metav1.Duration{}, // TODO: set default here
 		IncludeClusterResources: objectsSpec.IncludeClusterResources,