SQL Run results don't get updated when saving an edited sql string result

[anthony2261]

Privileged issue

• I'm @RamiAwar or he asked me directly to create an issue here.

Issue Content

-> Edit SQL string
-> Press Run
-> Press Save
-> Switch conversation and back
-> Correct edited sql string is shown, but old sql run result

[RamiAwar]

That's indeed something we forgot to add. I think it definitely makes sense to update the run result when we press run. I had this in mind but forgot to do it.

[anthony2261]

Should we do it when we press run or when we save? I think both options are valid, but it might make more sense to come back to a conversation where the sql commands have their corresponding runs and not an edited-but-unsaved version of the command

[anthony2261]

@RamiAwar coming back to this, should we just save the run results when we click "Run"? Keen on closing this

[RamiAwar]

Yeah I think this makes sense.

I'm touching that code heavily in my branch tho

[anthony2261]

Mmmm we could add the fix there, but your local changes aren't pushed yet. I think it's best to work on this fix only after your branch is merged