fix(android): re-analyze URL on ScanResultScreen load

ROOT CAUSE: Flags were ALWAYS EMPTY because:
1. Navigation passes url/verdict/score through URL params (persist)
2. flags was read from viewModel.uiState which changes/resets
3. From History: ViewModel state ≠ historical scan
4. Result: flags always emptyList()!

FIX: Re-analyze URL when screen loads using 2025 Compose produceState:
- Inject PhishingEngine via koinInject()
- Call analyze(url) in produceState block
- Fresh analysis provides real flags every time

Code pattern:
  val analysisResult by produceState<RiskAssessment?>(null, url) {
      value = phishingEngine.analyze(url)
  }
  val realFlags = analysisResult?.flags ?: emptyList()

Version: 1.20.18

Author: Raoof128

.agent/agent.md

@@ -185,6 +185,36 @@ Any important notes for future agents.
 
 ---
 
+# 🔧 December 30, 2025 (Session 10k+61) - Re-analyze URL on Screen Load
+
+### Summary
+Fixed flags not showing by re-analyzing URL when ScanResultScreen loads using 2025 Compose `produceState` pattern.
+
+## ✅ Root Cause
+
+**Problem:** Flags were ALWAYS EMPTY because:
+1. Navigation passes `url`, `verdict`, `score` through URL params (these persist)
+2. `flags` was read from `viewModel.uiState` which changes/resets
+3. When navigating from History, ViewModel state ≠ historical scan
+4. Result: `flags` always `emptyList()`!
+
+**Fix:** Re-analyze URL when screen loads using `produceState`:
+```kotlin
+val analysisResult by produceState<RiskAssessment?>(null, url) {
+    value = phishingEngine.analyze(url)
+}
+```
+
+## 📁 Files Modified
+
+| File | Change |
+|------|--------|
+| `ScanResultScreen.kt` | Use `produceState` + `koinInject<PhishingEngine>()` |
+| `Navigation.kt` | Removed stale flag extraction |
+| `CHANGELOG.md` | Version 1.20.18 |
+
+---
+
 # 🔧 December 30, 2025 (Session 10k+60) - Fix Flag Matching Logic
 
 ### Summary

CHANGELOG.md

@@ -8,6 +8,49 @@ All notable changes to QR-SHIELD will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
+## [1.20.18] - 2025-12-30
+
+### Raouf: Re-analyze URL on ScanResultScreen (2025-12-30 19:45 AEDT)
+
+**Scope:** Fix flags not showing - re-analyze URL when screen loads
+
+**Root Cause:**
+- Navigation passes `url`, `verdict`, `score` through URL parameters
+- `flags` was being read from ViewModel `uiState` which may not be in `Result` state
+- When navigating from History, ViewModel state is NOT the historical scan
+- Result: `flags` was always empty!
+
+**Fix Applied (2025 Compose Best Practice):**
+- Use `produceState` to call suspend `analyze()` function
+- Re-analyze URL when ScanResultScreen loads
+- Fresh analysis provides real flags every time
+
+**Code Change:**
+```kotlin
+// Before: flags passed through navigation (unreliable)
+val flags = assessment?.flags ?: emptyList()  // ALWAYS EMPTY!
+
+// After: re-analyze URL on screen load (2025 Compose pattern)
+val analysisResult by produceState<RiskAssessment?>(null, url) {
+    value = phishingEngine.analyze(url)
+}
+val realFlags = analysisResult?.flags ?: emptyList()
+```
+
+**Files Modified:**
+
+| File | Change |
+|------|--------|
+| `ScanResultScreen.kt` | Use `produceState` to call `phishingEngine.analyze(url)` on load |
+| `Navigation.kt` | Simplified - removed stale flag extraction |
+
+**Build Verification:**
+```bash
+./gradlew :androidApp:assembleDebug  # BUILD SUCCESSFUL ✅
+```
+
+---
+
 ## [1.20.17] - 2025-12-30
 
 ### Raouf: Fix Flag Matching - Wire ALL Decorative Data to Engine (2025-12-30 19:00 AEDT)

androidApp/src/main/kotlin/com/qrshield/android/ui/navigation/Navigation.kt

@@ -447,24 +447,11 @@ fun QRShieldNavHost(
             val verdict = backStackEntry.arguments?.getString("verdict") ?: "UNKNOWN"
             val score = backStackEntry.arguments?.getInt("score") ?: 0
 
-            // Extract real flags from current assessment in ViewModel
-            val uiState by viewModel.uiState.collectAsState()
-            val assessment = (uiState as? com.qrshield.ui.UiState.Result)?.assessment
-            val flags = assessment?.flags ?: emptyList()
-            val brandMatch = assessment?.details?.brandMatch
-            val tld = assessment?.details?.tld
-            val confidence = assessment?.confidence ?: 0.8f
-            val heuristicScore = assessment?.details?.heuristicScore ?: 0
-            
+            // ScanResultScreen now re-analyzes the URL internally for fresh flags
             ScanResultScreen(
                 url = url,
                 verdict = verdict,
                 score = score,
-                flags = flags,
-                brandMatch = brandMatch,
-                tld = tld,
-                engineConfidence = confidence,
-                heuristicScore = heuristicScore,
                 onBackClick = { navController.popBackStack() },
                 onShareClick = { 
                     val shareText = viewModel.generateShareText()

androidApp/src/main/kotlin/com/qrshield/android/ui/screens/ScanResultScreen.kt

@@ -63,12 +63,6 @@ fun ScanResultScreen(
     url: String = "https://example.com",
     verdict: String = "UNKNOWN",
     score: Int = 0,
-    // Real engine data (not hardcoded!)
-    flags: List<String> = emptyList(),
-    brandMatch: String? = null,
-    tld: String? = null,
-    engineConfidence: Float = 0.8f,
-    heuristicScore: Int = 0,
     // Callbacks
     onBackClick: () -> Unit = {},
     onShareClick: () -> Unit = {},
@@ -77,6 +71,29 @@ fun ScanResultScreen(
     onCopyUrl: () -> Unit = {},
     modifier: Modifier = Modifier
 ) {
+    // Get PhishingEngine to re-analyze for fresh flags
+    val phishingEngine: com.qrshield.core.PhishingEngine = org.koin.compose.koinInject()
+    
+    // Re-analyze URL to get REAL flags (not stale/empty data from navigation)
+    // Use produceState to call suspend function
+    val analysisResult by androidx.compose.runtime.produceState<com.qrshield.model.RiskAssessment?>(
+        initialValue = null,
+        key1 = url
+    ) {
+        value = try {
+            phishingEngine.analyze(url)
+        } catch (e: Exception) {
+            null
+        }
+    }
+    
+    // Use real data from fresh analysis
+    val realFlags = analysisResult?.flags ?: emptyList()
+    val realBrandMatch = analysisResult?.details?.brandMatch
+    val realTld = analysisResult?.details?.tld
+    val realConfidence = analysisResult?.confidence ?: 0.8f
+    val realHeuristicScore = analysisResult?.details?.heuristicScore ?: 0
+    
     // Derive display values from navigation params
     val displayVerdict = when (verdict.uppercase()) {
         "MALICIOUS" -> stringResource(R.string.verdict_malicious)
@@ -91,7 +108,7 @@ fun ScanResultScreen(
         else -> stringResource(R.string.threat_type_unknown)
     }
     // Use real engine confidence instead of hardcoded values
-    val confidence = (engineConfidence * 100).toInt().coerceIn(0, 100)
+    val confidence = (realConfidence * 100).toInt().coerceIn(0, 100)
     val severityScore = score / 10f
     val scrollState = rememberScrollState()
 
@@ -147,17 +164,17 @@ fun ScanResultScreen(
 
                 Spacer(modifier = Modifier.height(16.dp))
 
-                // Engine Stats - REAL data!
+                // Engine Stats - REAL data from fresh analysis!
                 EngineStatsCard(
-                    heuristicScore = heuristicScore,
-                    flagCount = flags.size,
+                    heuristicScore = realHeuristicScore,
+                    flagCount = realFlags.size,
                     modifier = Modifier.padding(horizontal = 16.dp)
                 )
 
                 Spacer(modifier = Modifier.height(16.dp))
 
                 // Tags/Chips - Dynamic from real flags!
-                TagsRow(flags = flags)
+                TagsRow(flags = realFlags)
 
                 Spacer(modifier = Modifier.height(24.dp))
 
@@ -179,11 +196,11 @@ fun ScanResultScreen(
 
                 Spacer(modifier = Modifier.height(24.dp))
 
-                // Analysis Breakdown - REAL engine data, not hardcoded!
+                // Analysis Breakdown - REAL engine data from fresh analysis!
                 AnalysisBreakdownSection(
-                    flags = flags,
-                    brandMatch = brandMatch,
-                    tld = tld,
+                    flags = realFlags,
+                    brandMatch = realBrandMatch,
+                    tld = realTld,
                     modifier = Modifier.padding(horizontal = 16.dp)
                 )