Unable to enable VPN Provider support

[fheinz]

I'm trying to follow the VPN Providers page from the documentation, but answering "Y" to the "Enable VPN provider client configuration?" question doesn't work:

RaspAP Install: Configure VPN provider support
Enable VPN provider client configuration? [Y/n]: Y
RaspAP Install: Installing VPN provider support
Invalid choice. The specified option does not exist.

What am I missing?

[billz]

I'm not able to repro this on a supported OS. Both pressing Enter for the default and entering 'Y' works as expected:

RaspAP Install: Configure VPN provider support
Enable VPN provider client configuration? [Y/n]: Y
RaspAP Install: Installing VPN provider support
Select an option from the list:
  1) ExpressVPN
  2) Mullvad VPN
  3) NordVPN
  4) AdGuard VPN
  0) None
Choose an option:

The installer parses vpn-providers.json using the jq package (installed in a previous step). If this file is missing or malformed it won't output the list.

Execute cat /etc/os-release and compare this against our supported OSs. You can also try which jq.

[fheinz]

I think I'm good on both the jq and the OS fronts:

$ which jq
/usr/bin/jq
$ cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 13 (trixie)"
NAME="Debian GNU/Linux"
VERSION_ID="13"
VERSION="13 (trixie)"
VERSION_CODENAME=trixie
DEBIAN_VERSION_FULL=13.3
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

vpn-providers.json also seems to be OK:

$ md5sum /var/www/html/config/vpn-providers.json
381e950550ec1899557e5e4d03bdcd22  /var/www/html/config/vpn-providers.json

If I execute the quick installer with /bin/bash -x, this is the relevant part of the debug output:

+ for feature in "${features[@]}"
+ IFS=:
+ read -r -a feature_details
+ _prompt_install_feature 'VPN provider' 'Enable VPN provider client configuration' pv_option _install_provider
+ local 'feature=VPN provider'
+ local 'prompt=Enable VPN provider client configuration'
+ local opt=pv_option
+ local function=_install_provider
+ _install_log 'Configure VPN provider support'
+ echo -e '\033[38;5;30mRaspAP Install: Configure VPN provider support\033[m'
RaspAP Install: Configure VPN provider support
+ echo -n 'Enable VPN provider client configuration? [Y/n]: '
Enable VPN provider client configuration? [Y/n]: + '[' 0 == 0 ']'
+ read answer
Y
+ '[' Y '!=' Y ']'
+ _install_provider
+ _install_log 'Installing VPN provider support'
+ echo -e '\033[38;5;30mRaspAP Install: Installing VPN provider support\033[m'
RaspAP Install: Installing VPN provider support
+ json=/var/www/html/config/vpn-providers.json
+ IFS='|'
+ read -r key value
++ jq -r '.providers[] | "\(.id)|\(.name)|\(.bin_path)"' /var/www/html/config/vpn-providers.json
+ options["$key"]='ExpressVPN|/usr/bin/expressvpn'
+ IFS='|'
+ read -r key value
+ options["$key"]='Mullvad VPN|/usr/bin/mullvad'
+ IFS='|'
+ read -r key value
+ options["$key"]='NordVPN|/usr/bin/nordvpn'
+ IFS='|'
+ read -r key value
+ options["$key"]='AdGuard VPN|/usr/local/bin/adguardvpn-cli'
+ IFS='|'
+ read -r key value
+ '[' -n 0 ']'
+ [[ -n '' ]]
+ echo 'Invalid choice. The specified option does not exist.'
Invalid choice. The specified option does not exist.
+ return 1

My bash is rather rusty, but the condition on line common.sh:510 (if [[ -n ${options[$pv_option]+abc} ]]) looks fishy to me.

[billz]

No repro here:

RaspAP Install: Configure VPN provider support
+ echo -n 'Enable VPN provider client configuration? [Y/n]: '
Enable VPN provider client configuration? [Y/n]: + '[' 0 == 0 ']'
+ read answer
Y
+ '[' Y '!=' Y ']'
+ _install_provider
+ _install_log 'Installing VPN provider support'
+ echo -e '\033[38;5;30mRaspAP Install: Installing VPN provider support\033[m'
RaspAP Install: Installing VPN provider support
+ json=/var/www/html/config/vpn-providers.json
+ IFS='|'
++ jq -r '.providers[] | "\(.id)|\(.name)|\(.bin_path)"' /var/www/html/config/vpn-providers.json
+ read -r key value
+ options["$key"]='ExpressVPN|/usr/bin/expressvpn'
+ IFS='|'
+ read -r key value
+ options["$key"]='Mullvad VPN|/usr/bin/mullvad'
+ IFS='|'
+ read -r key value
+ options["$key"]='NordVPN|/usr/bin/nordvpn'
+ IFS='|'
+ read -r key value
+ options["$key"]='AdGuard VPN|/usr/local/bin/adguardvpn-cli'
+ IFS='|'
+ read -r key value
+ '[' -n '' ']'
+ echo -e 'Select an option from the list:'
Select an option from the list:
+ true
+ for key in "${!options[@]}"
+ echo '  1) ExpressVPN'
  1) ExpressVPN
+ for key in "${!options[@]}"
+ echo '  2) Mullvad VPN'
  2) Mullvad VPN
+ for key in "${!options[@]}"
+ echo '  3) NordVPN'
  3) NordVPN
+ for key in "${!options[@]}"
+ echo '  4) AdGuard VPN'
  4) AdGuard VPN
+ echo '  0) None'
  0) None
+ echo -n 'Choose an option: '
Choose an option: + read answer

Best guess is pv_option=0 in set in your environment. Use unset pv_option. I don't see a bug/reason to modify the installer at this time.

[fheinz]

I think I found the issue: fheinz#1

[billz]

@fheinz nicely done! and I stand corrected. thanks for the PR