Skip to content

block factory generates incorrect javascript definitions for FieldImage #2692

@maribethb

Description

@maribethb

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

block factory

Description

See RaspberryPiFoundation/blockly#9942

the JS definition generated for blocks that contain a FieldImage is wrong. it has been wrong for a long time including in the legacy factory. the 4th argument is the config arg whereas the FieldImage constructor takes that as the seventh argument (and there's no need for it anyway as it could pass the alt text and flipRtl directly as the 4th and 5th arguments to the constructor)

Reproduction steps

Stack trace

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions